test: reap old instances before system tests (#687)

Author: JustinBeckwith

handwritten/bigtable/package.json

@@ -30,9 +30,9 @@
     "docs": "jsdoc -c .jsdoc.js",
     "predocs-test": "npm run docs",
     "docs-test": "linkinator docs",
-    "fix": "gts fix && eslint '**/*.js' --fix",
+    "fix": "gts fix",
     "prelint": "cd samples; npm link ../; npm i",
-    "lint": "gts check && eslint samples/*.js",
+    "lint": "gts check",
     "prepare": "npm run compile",
     "samples-test": "cd samples/ && npm link ../ && npm install && npm test && cd ../",
     "snippet-test": "mocha samples/document-snippets/tests/*.js --timeout 600000",
@@ -79,10 +79,6 @@
     "@types/uuid": "^7.0.0",
     "c8": "^7.1.0",
     "codecov": "^3.6.5",
-    "eslint": "^6.8.0",
-    "eslint-config-prettier": "^6.10.0",
-    "eslint-plugin-node": "^11.0.0",
-    "eslint-plugin-prettier": "^3.1.2",
     "google-auth-library": "^6.0.0",
     "gts": "2.0.0-alpha.9",
     "jsdoc": "^3.6.3",
@@ -96,8 +92,6 @@
     "null-loader": "^3.0.0",
     "p-queue": "^6.0.2",
     "pack-n-play": "^1.0.0-2",
-    "power-assert": "^1.6.1",
-    "prettier": "^1.19.1",
     "proxyquire": "^2.0.0",
     "sinon": "^9.0.1",
     "ts-loader": "^6.2.1",

handwritten/bigtable/system-test/bigtable.ts

@@ -35,7 +35,26 @@ describe('Bigtable', () => {
   const APP_PROFILE = INSTANCE.appProfile(APP_PROFILE_ID);
   const CLUSTER_ID = generateId('cluster');
 
+  async function reapInstances() {
+    const [instances] = await bigtable.getInstances();
+    const testInstances = instances
+      .filter(i => i.id.match(PREFIX))
+      .filter(i => {
+        const timeCreated = (i.metadata!.labels!.time_created as {}) as Date;
+        // Only delete stale resources.
+        const oneHourAgo = new Date(Date.now() - 3600000);
+        return !timeCreated || timeCreated <= oneHourAgo;
+      });
+    const q = new Q({concurrency: 5});
+    await Promise.all(
+      testInstances.map(instance => {
+        q.add(() => instance.delete());
+      })
+    );
+  }
+
   before(async () => {
+    await reapInstances();
     const [, operation] = await INSTANCE.create({
       clusters: [
         {
@@ -59,21 +78,7 @@ describe('Bigtable', () => {
   });
 
   after(async () => {
-    const [instances] = await bigtable.getInstances();
-    const testInstances = instances
-      .filter(i => i.id.match(PREFIX))
-      .filter(i => {
-        const timeCreated = (i.metadata!.labels!.time_created as {}) as Date;
-        // Only delete stale resources.
-        const oneHourAgo = new Date(Date.now() - 3600000);
-        return !timeCreated || timeCreated <= oneHourAgo;
-      });
-    const q = new Q({concurrency: 5});
-    await Promise.all(
-      testInstances.map(instance => {
-        q.add(() => instance.delete());
-      })
-    );
+    await INSTANCE.delete().catch(console.error);
   });
 
   describe('instances', () => {

handwritten/bigtable/system-test/install.ts

@@ -21,7 +21,7 @@ import {readFileSync} from 'fs';
 import {describe, it} from 'mocha';
 
 describe('typescript consumer tests', () => {
-  it('should have correct type signature for typescript users', async function() {
+  it('should have correct type signature for typescript users', async function () {
     this.timeout(300000);
     const options = {
       packageDir: process.cwd(), // path to your module.
@@ -35,7 +35,7 @@ describe('typescript consumer tests', () => {
     await packNTest(options); // will throw upon error.
   });
 
-  it('should have correct type signature for javascript users', async function() {
+  it('should have correct type signature for javascript users', async function () {
     this.timeout(300000);
     const options = {
       packageDir: process.cwd(), // path to your module.

handwritten/bigtable/test/index.ts

@@ -633,7 +633,7 @@ describe('Bigtable', () => {
           [CONFIG.method]: noop,
         };
         // eslint-disable-next-line @typescript-eslint/no-explicit-any
-        (fakeV2 as any)[CONFIG.client] = function(options: any) {
+        (fakeV2 as any)[CONFIG.client] = function (options: any) {
           assert.strictEqual(options, bigtable.options[CONFIG.client]);
           return fakeClient;
         };
@@ -644,7 +644,7 @@ describe('Bigtable', () => {
 
       it('should use the cached client', done => {
         // eslint-disable-next-line @typescript-eslint/no-explicit-any
-        (fakeV2 as any)[CONFIG.client] = function() {
+        (fakeV2 as any)[CONFIG.client] = function () {
           done(new Error('Should not re-instantiate a GAX client.'));
         };
         bigtable.request(CONFIG);

handwritten/bigtable/test/table.ts

@@ -71,7 +71,7 @@ FakeRow.formatChunks_ = sinon.spy(chunks => {
 });
 
 const FakeChunkTransformer = createFake(ChunkTransformer);
-FakeChunkTransformer.prototype._transform = function(
+FakeChunkTransformer.prototype._transform = function (
   rows: Row[],
   enc: {},
   next: Function
@@ -808,7 +808,7 @@ describe('Bigtable/Table', () => {
         sinon.stub(table, 'row').callsFake(() => {
           return {} as Row;
         });
-        FakeChunkTransformer.prototype._transform = function(
+        FakeChunkTransformer.prototype._transform = function (
           chunks: Array<{}>,
           enc: {},
           next: Function
@@ -990,7 +990,7 @@ describe('Bigtable/Table', () => {
       let setTimeoutSpy: sinon.SinonSpy;
 
       beforeEach(() => {
-        FakeChunkTransformer.prototype._transform = function(
+        FakeChunkTransformer.prototype._transform = function (
           rows: Row[],
           enc: {},
           next: Function
@@ -1005,10 +1005,7 @@ describe('Bigtable/Table', () => {
         };
 
         callCreateReadStream = (options: {}, verify: Function) => {
-          table
-            .createReadStream(options)
-            .on('end', verify)
-            .resume(); // The stream starts paused unless it has a `.data()`
+          table.createReadStream(options).on('end', verify).resume(); // The stream starts paused unless it has a `.data()`
           // callback.
         };