Skip to content

Commit c294b0e

Browse files
authored
feat: Use small request dependency (#98)
Pass teeny-request to common. Service so we don't rely on request.
1 parent dd6d72d commit c294b0e

2 files changed

Lines changed: 8 additions & 3 deletions

File tree

packages/google-cloud-translate/package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,12 +67,13 @@
6767
"presystem-test": "npm run compile"
6868
},
6969
"dependencies": {
70-
"@google-cloud/common": "^0.21.0",
70+
"@google-cloud/common": "^0.23.0",
7171
"@google-cloud/promisify": "^0.3.0",
7272
"arrify": "^1.0.1",
7373
"extend": "^3.0.1",
7474
"is": "^3.2.1",
75-
"is-html": "^1.1.0"
75+
"is-html": "^1.1.0",
76+
"teeny-request": "^3.4.0"
7677
},
7778
"devDependencies": {
7879
"@google-cloud/nodejs-repo-tools": "^2.3.0",

packages/google-cloud-translate/src/index.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ import * as is from 'is';
2525
const isHtml = require('is-html');
2626
import {DecorateRequestOptions, BodyResponseCallback} from '@google-cloud/common/build/src/util';
2727
import * as r from 'request';
28+
import {teenyRequest} from 'teeny-request';
2829

2930
const PKG = require('../../package.json');
3031

@@ -148,6 +149,7 @@ export interface TranslateConfig extends GoogleAuthOptions {
148149
key?: string;
149150
autoRetry?: boolean;
150151
maxRetries?: number;
152+
requestModule?: typeof teenyRequest;
151153
}
152154

153155
/**
@@ -191,10 +193,12 @@ export class Translate extends Service {
191193
scopes: ['https://www.googleapis.com/auth/cloud-platform'],
192194
packageJson: require('../../package.json'),
193195
projectIdRequired: false,
196+
requestModule: teenyRequest as typeof r,
194197
};
195198

196199
super(config, options);
197200
this.options = options || {};
201+
this.options.requestModule = config.requestModule;
198202
if (this.options.key) {
199203
this.key = this.options.key;
200204
}
@@ -544,7 +548,7 @@ export class Translate extends Service {
544548
},
545549
});
546550

547-
util.makeRequest(reqOpts, this.options!, callback!);
551+
util.makeRequest(reqOpts, this.options, callback!);
548552
}
549553
}
550554

0 commit comments

Comments
 (0)