Skip to content

Commit cd24de2

Browse files
Revert "updated FQDN's to googleapis.com with a trailing dot (#2214)" (#2283)
This reverts commit 13d4ed5.
1 parent c9aa2cc commit cd24de2

4 files changed

Lines changed: 6 additions & 6 deletions

File tree

handwritten/storage/src/file.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,13 +60,13 @@ var SigningError = createErrorClass('SigningError', function(message) {
6060
* @const {string}
6161
* @private
6262
*/
63-
var STORAGE_DOWNLOAD_BASE_URL = 'https://storage.googleapis.com.';
63+
var STORAGE_DOWNLOAD_BASE_URL = 'https://storage.googleapis.com';
6464

6565
/**
6666
* @const {string}
6767
* @private
6868
*/
69-
var STORAGE_UPLOAD_BASE_URL = 'https://www.googleapis.com./upload/storage/v1/b';
69+
var STORAGE_UPLOAD_BASE_URL = 'https://www.googleapis.com/upload/storage/v1/b';
7070

7171
/**
7272
* @const {RegExp}

handwritten/storage/src/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ function Storage(options) {
7676
}
7777

7878
var config = {
79-
baseUrl: 'https://www.googleapis.com./storage/v1',
79+
baseUrl: 'https://www.googleapis.com/storage/v1',
8080
projectIdRequired: false,
8181
scopes: [
8282
'https://www.googleapis.com/auth/devstorage.full_control'

handwritten/storage/test/file.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -622,7 +622,7 @@ describe('File', function() {
622622
describe('authenticating', function() {
623623
it('should create an authenticated request', function(done) {
624624
var expectedPath = format('https://{host}/{b}/{o}', {
625-
host: 'storage.googleapis.com.',
625+
host: 'storage.googleapis.com',
626626
b: file.bucket.name,
627627
o: encodeURIComponent(file.name)
628628
});
@@ -2588,7 +2588,7 @@ describe('File', function() {
25882588
name: file.name,
25892589
predefinedAcl: options.predefinedAcl
25902590
},
2591-
uri: 'https://www.googleapis.com./upload/storage/v1/b/' +
2591+
uri: 'https://www.googleapis.com/upload/storage/v1/b/' +
25922592
file.bucket.name + '/o'
25932593
});
25942594
done();

handwritten/storage/test/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ describe('Storage', function() {
123123

124124
var calledWith = storage.calledWith_[0];
125125

126-
var baseUrl = 'https://www.googleapis.com./storage/v1';
126+
var baseUrl = 'https://www.googleapis.com/storage/v1';
127127
assert.strictEqual(calledWith.baseUrl, baseUrl);
128128
assert.strictEqual(calledWith.projectIdRequired, false);
129129
assert.deepEqual(calledWith.scopes, [

0 commit comments

Comments
 (0)