refactor: enable noImplicitAny (#618)

Author: JustinBeckwith

handwritten/logging/package.json

@@ -87,6 +87,7 @@
     "@types/pumpify": "^1.4.1",
     "@types/sinon": "^7.0.8",
     "@types/through2": "^2.0.34",
+    "@types/tmp": "^0.1.0",
     "@types/uuid": "^3.4.4",
     "assert-rejects": "^1.0.0",
     "bignumber.js": "^9.0.0",
@@ -95,6 +96,7 @@
     "eslint-config-prettier": "^6.0.0",
     "eslint-plugin-node": "^10.0.0",
     "eslint-plugin-prettier": "^3.0.0",
+    "execa": "^3.2.0",
     "google-proto-files": "^1.0.0",
     "gts": "^1.0.0",
     "http2spy": "^1.1.0",

handwritten/logging/src/log.ts

@@ -826,19 +826,19 @@ class Log implements LogSeverityFunctions {
       return writeWithResource(resource);
     }
     async function writeWithResource(resource: {} | null) {
-      let decoratedEntries;
+      let decoratedEntries: EntryJson[];
       try {
         decoratedEntries = self.decorateEntries_(arrify(entry) as Entry[]);
       } catch (err) {
         // Ignore errors (the API will speak up if it has an issue).
       }
-      self.truncateEntries(decoratedEntries);
+      self.truncateEntries(decoratedEntries!);
       const projectId = await self.logging.auth.getProjectId();
       self.formattedName_ = Log.formatName_(projectId, self.name);
       const reqOpts = extend(
         {
           logName: self.formattedName_,
-          entries: decoratedEntries,
+          entries: decoratedEntries!,
           resource,
         },
         options

handwritten/logging/system-test/install.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import * as execa from 'execa';
+import execa = require('execa');
 import * as mv from 'mv';
 import {ncp} from 'ncp';
 import * as tmp from 'tmp';

handwritten/logging/system-test/logging.ts

@@ -22,8 +22,8 @@ import {HOST_ADDRESS} from 'gcp-metadata';
 import * as nock from 'nock';
 import {Duplex} from 'stream';
 import * as uuid from 'uuid';
-import * as http2spy from 'http2spy';
-import {Logging, Sink} from '../src';
+const http2spy = require('http2spy');
+import {Logging, Sink, Log, Entry} from '../src';
 
 // block all attempts to chat with the metadata server (kokoro runs on GCE)
 nock(HOST_ADDRESS)
@@ -99,7 +99,8 @@ describe('Logging', () => {
     async function getAndDelete(method: Function) {
       const [objects] = await method();
       return Promise.all(
-        objects
+        // tslint:disable-next-line no-any
+        (objects as any[])
           .filter(o => {
             const name = o.name || o.id;
             if (!name.startsWith(TESTS_PREFIX)) {
@@ -242,7 +243,10 @@ describe('Logging', () => {
       return {log, logEntries};
     }
 
-    function getEntriesFromLog(log, callback) {
+    function getEntriesFromLog(
+      log: Log,
+      callback: (err: Error | null, entries?: Entry[]) => void
+    ) {
       let numAttempts = 0;
 
       setTimeout(pollForMessages, WRITE_CONSISTENCY_DELAY_MS);
@@ -303,7 +307,7 @@ describe('Logging', () => {
 
         getEntriesFromLog(log, (err, entries) => {
           assert.ifError(err);
-          assert.strictEqual(entries.length, logEntries.length);
+          assert.strictEqual(entries!.length, logEntries.length);
           done();
         });
       });
@@ -327,7 +331,8 @@ describe('Logging', () => {
     });
 
     describe('log-specific entries', () => {
-      let logExpected, logEntriesExpected;
+      let logExpected: Log;
+      let logEntriesExpected: Entry[];
 
       before(done => {
         const {log, logEntries} = getTestLog();
@@ -339,7 +344,7 @@ describe('Logging', () => {
       it('should list log entries', done => {
         getEntriesFromLog(logExpected, (err, entries) => {
           assert.ifError(err);
-          assert.strictEqual(entries.length, logEntriesExpected.length);
+          assert.strictEqual(entries!.length, logEntriesExpected.length);
           done();
         });
       });
@@ -377,7 +382,7 @@ describe('Logging', () => {
         getEntriesFromLog(log, (err, entries) => {
           assert.ifError(err);
 
-          assert.deepStrictEqual(entries.map(x => x.data).reverse(), [
+          assert.deepStrictEqual(entries!.map(x => x.data).reverse(), [
             'log entry 1',
             {delegate: 'my_username'},
             {
@@ -595,7 +600,7 @@ describe('Logging', () => {
   // Parse the time the resource was created using the resource id
   // Format 1: ${TESTS_PREFIX}-${date}-${uuid}
   // Format 2: ${TESTS_PREFIX}_${date}_${uuid}
-  function getDateFromGeneratedName(name) {
+  function getDateFromGeneratedName(name: string) {
     const timeCreated = name.substr(TESTS_PREFIX.length + 1).split(/-|_/g)[0];
     return new Date(Number(timeCreated));
   }