Skip to content

Commit f9aa914

Browse files
JustinBeckwithJustinBeckwith
authored
refactor(ts): enable noImplicitThis (#316)
1 parent 669f365 commit f9aa914

6 files changed

Lines changed: 36 additions & 34 deletions

File tree

‎handwritten/pubsub/samples/quickstart.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
// [START pubsub_quickstart_create_topic]
1919
// Imports the Google Cloud client library
20-
const PubSub = require('@google-cloud/pubsub');
20+
const {PubSub} = require('@google-cloud/pubsub');
2121

2222
// Your Google Cloud Platform project ID
2323
const projectId = 'YOUR_PROJECT_ID';

‎handwritten/pubsub/samples/subscriptions.js‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
function listSubscriptions() {
2727
// [START pubsub_list_subscriptions]
2828
// Imports the Google Cloud client library
29-
const PubSub = require(`@google-cloud/pubsub`);
29+
const {PubSub} = require('@google-cloud/pubsub');
3030

3131
// Creates a client
3232
const pubsub = new PubSub();
@@ -49,7 +49,7 @@ function listSubscriptions() {
4949
function listTopicSubscriptions(topicName) {
5050
// [START pubsub_list_topic_subscriptions]
5151
// Imports the Google Cloud client library
52-
const PubSub = require(`@google-cloud/pubsub`);
52+
const {PubSub} = require('@google-cloud/pubsub');
5353

5454
// Creates a client
5555
const pubsub = new PubSub();
@@ -78,7 +78,7 @@ function listTopicSubscriptions(topicName) {
7878
function createSubscription(topicName, subscriptionName) {
7979
// [START pubsub_create_pull_subscription]
8080
// Imports the Google Cloud client library
81-
const PubSub = require(`@google-cloud/pubsub`);
81+
const {PubSub} = require('@google-cloud/pubsub');
8282

8383
// Creates a client
8484
const pubsub = new PubSub();
@@ -111,7 +111,7 @@ function createFlowControlledSubscription(
111111
) {
112112
// [START pubsub_subscriber_flow_settings]
113113
// Imports the Google Cloud client library
114-
const PubSub = require(`@google-cloud/pubsub`);
114+
const {PubSub} = require('@google-cloud/pubsub');
115115

116116
// Creates a client
117117
const pubsub = new PubSub();
@@ -159,7 +159,7 @@ function createFlowControlledSubscription(
159159
function createPushSubscription(topicName, subscriptionName) {
160160
// [START pubsub_create_push_subscription]
161161
// Imports the Google Cloud client library
162-
const PubSub = require(`@google-cloud/pubsub`);
162+
const {PubSub} = require('@google-cloud/pubsub');
163163

164164
// Creates a client
165165
const pubsub = new PubSub();
@@ -195,7 +195,7 @@ function createPushSubscription(topicName, subscriptionName) {
195195
function modifyPushConfig(topicName, subscriptionName) {
196196
// [START pubsub_update_push_configuration]
197197
// Imports the Google Cloud client library
198-
const PubSub = require(`@google-cloud/pubsub`);
198+
const {PubSub} = require('@google-cloud/pubsub');
199199

200200
// Creates a client
201201
const pubsub = new PubSub();
@@ -228,7 +228,7 @@ function modifyPushConfig(topicName, subscriptionName) {
228228
function deleteSubscription(subscriptionName) {
229229
// [START pubsub_delete_subscription]
230230
// Imports the Google Cloud client library
231-
const PubSub = require(`@google-cloud/pubsub`);
231+
const {PubSub} = require('@google-cloud/pubsub');
232232

233233
// Creates a client
234234
const pubsub = new PubSub();
@@ -253,7 +253,7 @@ function deleteSubscription(subscriptionName) {
253253

254254
function getSubscription(subscriptionName) {
255255
// Imports the Google Cloud client library
256-
const PubSub = require(`@google-cloud/pubsub`);
256+
const {PubSub} = require('@google-cloud/pubsub');
257257

258258
// Creates a client
259259
const pubsub = new PubSub();
@@ -284,7 +284,7 @@ function listenForMessages(subscriptionName, timeout) {
284284
// [START pubsub_subscriber_async_pull]
285285
// [START pubsub_quickstart_subscriber]
286286
// Imports the Google Cloud client library
287-
const PubSub = require(`@google-cloud/pubsub`);
287+
const {PubSub} = require('@google-cloud/pubsub');
288288

289289
// Creates a client
290290
const pubsub = new PubSub();
@@ -441,7 +441,7 @@ const outstandingMessages = {};
441441

442442
function listenForOrderedMessages(subscriptionName, timeout) {
443443
// Imports the Google Cloud client library
444-
const PubSub = require(`@google-cloud/pubsub`);
444+
const {PubSub} = require('@google-cloud/pubsub');
445445

446446
// Creates a client
447447
const pubsub = new PubSub();
@@ -504,7 +504,7 @@ function listenForOrderedMessages(subscriptionName, timeout) {
504504
function listenForErrors(subscriptionName, timeout) {
505505
// [START pubsub_subscriber_error_listener]
506506
// Imports the Google Cloud client library
507-
const PubSub = require(`@google-cloud/pubsub`);
507+
const {PubSub} = require('@google-cloud/pubsub');
508508

509509
// Creates a client
510510
const pubsub = new PubSub();
@@ -547,7 +547,7 @@ function listenForErrors(subscriptionName, timeout) {
547547
function getSubscriptionPolicy(subscriptionName) {
548548
// [START pubsub_get_subscription_policy]
549549
// Imports the Google Cloud client library
550-
const PubSub = require(`@google-cloud/pubsub`);
550+
const {PubSub} = require('@google-cloud/pubsub');
551551

552552
// Creates a client
553553
const pubsub = new PubSub();
@@ -574,7 +574,7 @@ function getSubscriptionPolicy(subscriptionName) {
574574
function setSubscriptionPolicy(subscriptionName) {
575575
// [START pubsub_set_subscription_policy]
576576
// Imports the Google Cloud client library
577-
const PubSub = require(`@google-cloud/pubsub`);
577+
const {PubSub} = require('@google-cloud/pubsub');
578578

579579
// Creates a client
580580
const pubsub = new PubSub();
@@ -620,7 +620,7 @@ function setSubscriptionPolicy(subscriptionName) {
620620
function testSubscriptionPermissions(subscriptionName) {
621621
// [START pubsub_test_subscription_permissions]
622622
// Imports the Google Cloud client library
623-
const PubSub = require(`@google-cloud/pubsub`);
623+
const {PubSub} = require('@google-cloud/pubsub');
624624

625625
// Creates a client
626626
const pubsub = new PubSub();

‎handwritten/pubsub/samples/system-test/quickstart.test.js‎

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@
1515

1616
'use strict';
1717

18-
const proxyquire = require(`proxyquire`).noPreserveCache();
19-
const PubSub = proxyquire(`@google-cloud/pubsub`, {});
20-
const sinon = require(`sinon`);
21-
const test = require(`ava`);
22-
const tools = require(`@google-cloud/nodejs-repo-tools`);
23-
const uuid = require(`uuid`);
18+
const proxyquire = require('proxyquire').noPreserveCache();
19+
const {PubSub} = proxyquire('@google-cloud/pubsub', {});
20+
const sinon = require('sinon');
21+
const test = require('ava');
22+
const tools = require('@google-cloud/nodejs-repo-tools');
23+
const uuid = require('uuid');
2424

2525
const projectId = process.env.GCLOUD_PROJECT;
2626
const pubsub = new PubSub({projectId});
@@ -61,6 +61,8 @@ test.cb(`should create a topic`, t => {
6161
};
6262

6363
proxyquire(`../quickstart`, {
64-
'@google-cloud/pubsub': sinon.stub().returns(pubsubMock),
64+
'@google-cloud/pubsub': {
65+
PubSub: sinon.stub().returns(pubsubMock),
66+
},
6567
});
6668
});

‎handwritten/pubsub/samples/system-test/subscriptions.test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
'use strict';
1717

1818
const path = require(`path`);
19-
const PubSub = require(`@google-cloud/pubsub`);
19+
const {PubSub} = require('@google-cloud/pubsub');
2020
const test = require(`ava`);
2121
const tools = require(`@google-cloud/nodejs-repo-tools`);
2222
const uuid = require(`uuid`);

‎handwritten/pubsub/samples/system-test/topics.test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
'use strict';
1717

1818
const path = require(`path`);
19-
const PubSub = require(`@google-cloud/pubsub`);
19+
const {PubSub} = require('@google-cloud/pubsub');
2020
const test = require(`ava`);
2121
const tools = require(`@google-cloud/nodejs-repo-tools`);
2222
const uuid = require(`uuid`);

‎handwritten/pubsub/samples/topics.js‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
function listAllTopics() {
2727
// [START pubsub_list_topics]
2828
// Imports the Google Cloud client library
29-
const PubSub = require(`@google-cloud/pubsub`);
29+
const {PubSub} = require('@google-cloud/pubsub');
3030

3131
// Creates a client
3232
const pubsub = new PubSub();
@@ -49,7 +49,7 @@ function listAllTopics() {
4949
function createTopic(topicName) {
5050
// [START pubsub_create_topic]
5151
// Imports the Google Cloud client library
52-
const PubSub = require(`@google-cloud/pubsub`);
52+
const {PubSub} = require('@google-cloud/pubsub');
5353

5454
// Creates a client
5555
const pubsub = new PubSub();
@@ -75,7 +75,7 @@ function createTopic(topicName) {
7575
function deleteTopic(topicName) {
7676
// [START pubsub_delete_topic]
7777
// Imports the Google Cloud client library
78-
const PubSub = require(`@google-cloud/pubsub`);
78+
const {PubSub} = require('@google-cloud/pubsub');
7979

8080
// Creates a client
8181
const pubsub = new PubSub();
@@ -102,7 +102,7 @@ function publishMessage(topicName, data) {
102102
// [START pubsub_publish]
103103
// [START pubsub_quickstart_publisher]
104104
// Imports the Google Cloud client library
105-
const PubSub = require(`@google-cloud/pubsub`);
105+
const {PubSub} = require('@google-cloud/pubsub');
106106

107107
// Creates a client
108108
const pubsub = new PubSub();
@@ -133,7 +133,7 @@ function publishMessage(topicName, data) {
133133
function publishMessageWithCustomAttributes(topicName, data) {
134134
// [START pubsub_publish_custom_attributes]
135135
// Imports the Google Cloud client library
136-
const PubSub = require(`@google-cloud/pubsub`);
136+
const {PubSub} = require('@google-cloud/pubsub');
137137

138138
// Creates a client
139139
const pubsub = new PubSub();
@@ -168,7 +168,7 @@ function publishMessageWithCustomAttributes(topicName, data) {
168168
function publishBatchedMessages(topicName, data, maxMessages, maxWaitTime) {
169169
// [START pubsub_publisher_batch_settings]
170170
// Imports the Google Cloud client library
171-
const PubSub = require(`@google-cloud/pubsub`);
171+
const {PubSub} = require('@google-cloud/pubsub');
172172

173173
// Creates a client
174174
const pubsub = new PubSub();
@@ -216,7 +216,7 @@ function setPublishCounterValue(value) {
216216
function publishOrderedMessage(topicName, data) {
217217
// [START pubsub_publish_ordered_message]
218218
// Imports the Google Cloud client library
219-
const PubSub = require(`@google-cloud/pubsub`);
219+
const {PubSub} = require('@google-cloud/pubsub');
220220

221221
// Creates a client
222222
const pubsub = new PubSub();
@@ -259,7 +259,7 @@ function publishOrderedMessage(topicName, data) {
259259
function getTopicPolicy(topicName) {
260260
// [START pubsub_get_topic_policy]
261261
// Imports the Google Cloud client library
262-
const PubSub = require(`@google-cloud/pubsub`);
262+
const {PubSub} = require('@google-cloud/pubsub');
263263

264264
// Creates a client
265265
const pubsub = new PubSub();
@@ -286,7 +286,7 @@ function getTopicPolicy(topicName) {
286286
function setTopicPolicy(topicName) {
287287
// [START pubsub_set_topic_policy]
288288
// Imports the Google Cloud client library
289-
const PubSub = require(`@google-cloud/pubsub`);
289+
const {PubSub} = require('@google-cloud/pubsub');
290290

291291
// Creates a client
292292
const pubsub = new PubSub();
@@ -329,7 +329,7 @@ function setTopicPolicy(topicName) {
329329
function testTopicPermissions(topicName) {
330330
// [START pubsub_test_topic_permissions]
331331
// Imports the Google Cloud client library
332-
const PubSub = require(`@google-cloud/pubsub`);
332+
const {PubSub} = require('@google-cloud/pubsub');
333333

334334
// Creates a client
335335
const pubsub = new PubSub();

0 commit comments

Comments
 (0)
⚡