style: remove eslint ignores (#698)

* refactor: remove all eslint ignores

* fix: gts command

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Author: d-goog

core/packages/gaxios/package.json

@@ -20,7 +20,7 @@
     }
   },
   "scripts": {
-    "lint": "gts check",
+    "lint": "gts check --no-inline-config",
     "test": "c8 mocha build/esm/test",
     "presystem-test": "npm run compile",
     "system-test": "mocha build/esm/system-test --timeout 80000",

core/packages/gaxios/src/common.ts

@@ -56,8 +56,7 @@ export interface AIPErrorInterface {
  */
 export const GAXIOS_ERROR_SYMBOL = Symbol.for(`${pkg.name}-gaxios-error`);
 
-/* eslint-disable-next-line @typescript-eslint/no-explicit-any */
-export class GaxiosError<T = any> extends Error {
+export class GaxiosError<T = ReturnType<JSON['parse']>> extends Error {
   /**
    * An error code.
    * Can be a system error code, DOMException error name, or any error's 'code' property where it is a `string`.

core/packages/gaxios/src/gaxios.ts

@@ -135,7 +135,9 @@ export class Gaxios implements FetchCompliance {
    * Perform an HTTP request with the given options.
    * @param opts Set of HTTP options that will be used for this HTTP request.
    */
-  async request<T = any>(opts: GaxiosOptions = {}): GaxiosPromise<T> {
+  async request<T = ReturnType<JSON['parse']>>(
+    opts: GaxiosOptions = {},
+  ): GaxiosPromise<T> {
     let prepared = await this.#prepareRequest(opts);
     prepared = await this.#applyRequestInterceptors(prepared);
     return this.#applyResponseInterceptors(this._request(prepared));
@@ -177,7 +179,7 @@ export class Gaxios implements FetchCompliance {
    * Internal, retryable version of the `request` method.
    * @param opts Set of HTTP options that will be used for this HTTP request.
    */
-  protected async _request<T = any>(
+  protected async _request<T = ReturnType<JSON['parse']>>(
     opts: GaxiosOptionsPrepared,
   ): GaxiosPromise<T> {
     try {
@@ -252,7 +254,7 @@ export class Gaxios implements FetchCompliance {
   private async getResponseData(
     opts: GaxiosOptionsPrepared,
     res: Response,
-  ): Promise<any> {
+  ): Promise<ReturnType<JSON['parse']>> {
     if (
       opts.maxContentLength &&
       res.headers.has('content-length') &&
@@ -572,11 +574,11 @@ export class Gaxios implements FetchCompliance {
   /**
    * Attempts to parse a response by looking at the Content-Type header.
    * @param {Response} response the HTTP response.
-   * @returns {Promise<any>} a promise that resolves to the response data.
+   * @returns a promise that resolves to the response data.
    */
   private async getResponseDataFromContentType(
     response: Response,
-  ): Promise<any> {
+  ): Promise<ReturnType<JSON['parse']>> {
     let contentType = response.headers.get('Content-Type');
     if (contentType === null) {
       // Maintain existing functionality by calling text()

core/packages/gaxios/test/test.getch.ts

@@ -1237,8 +1237,7 @@ describe('🍂 defaults & instances', () => {
       getAgentCache() {
         return this.agentCache;
       }
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      protected async _request<T = any>(
+      protected async _request<T = ReturnType<JSON['parse']>>(
         opts: GaxiosOptionsPrepared,
       ): GaxiosPromise<T> {
         assert(opts.agent);

core/packages/gaxios/test/test.retry.ts

@@ -104,10 +104,10 @@ describe('🛸 retry & exponential backoff', () => {
     try {
       await req;
       throw Error('unreachable');
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    } catch (err: any) {
+    } catch (err) {
+      assert(err instanceof GaxiosError);
       assert(err.config);
-      assert.strictEqual(err.config.retryConfig.currentRetryAttempt, 0);
+      assert.strictEqual(err.config.retryConfig?.currentRetryAttempt, 0);
     }
   });