Skip to content

fix: Revert "fix: Do not publish the protos to npm"#8096

Merged
gcf-merge-on-green[bot] merged 1 commit intomainfrom
revert-8079-protos-do-not-publish
Apr 22, 2026
Merged

fix: Revert "fix: Do not publish the protos to npm"#8096
gcf-merge-on-green[bot] merged 1 commit intomainfrom
revert-8079-protos-do-not-publish

Conversation

@danieljbruce
Copy link
Copy Markdown
Contributor

@danieljbruce danieljbruce commented Apr 22, 2026

Description

Before we merge this PR, let's make sure fewer files are generated.

Impact

Reverses a change that excludes too many files, some of which may be necessary for the client library.

@danieljbruce danieljbruce requested a review from a team as a code owner April 22, 2026 18:12
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the package.json files across a large number of Google Cloud Node.js client libraries to include the build/protos directory in the published package files. This change ensures that protocol buffer definitions are correctly bundled with the distributed npm packages. I have no feedback to provide as the implementation is consistent across all affected packages.

Copy link
Copy Markdown
Contributor

@quirogas quirogas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reverting this change. For posterity, we are reverting this change because the proto/ directory also contains .js and .ts files, so we have to implement a more granular exclusion to avoid removing those altogether.

for #4820

@danieljbruce danieljbruce added the automerge Merge the pull request once unit tests and other checks pass. label Apr 22, 2026
@gcf-merge-on-green gcf-merge-on-green Bot merged commit ac0fbb6 into main Apr 22, 2026
32 checks passed
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 22, 2026
@gcf-merge-on-green gcf-merge-on-green Bot deleted the revert-8079-protos-do-not-publish branch April 22, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants