diff --git a/packages/google-container/protos/google/container/v1/cluster_service.proto b/packages/google-container/protos/google/container/v1/cluster_service.proto index 0f410bab4e33..4fb096621a9f 100644 --- a/packages/google-container/protos/google/container/v1/cluster_service.proto +++ b/packages/google-container/protos/google/container/v1/cluster_service.proto @@ -684,7 +684,9 @@ message NodeConfig { map metadata = 4; // The image type to use for this node. Note that for a given image type, - // the latest version of it will be used. + // the latest version of it will be used. Please see + // https://cloud.google.com/kubernetes-engine/docs/concepts/node-images for + // available image types. string image_type = 5; // The map of Kubernetes labels (key/value pairs) to be applied to each node. @@ -2299,7 +2301,9 @@ message UpdateNodePoolRequest { // - "-": picks the Kubernetes master version string node_version = 5 [(google.api.field_behavior) = REQUIRED]; - // Required. The desired image type for the node pool. + // Required. The desired image type for the node pool. Please see + // https://cloud.google.com/kubernetes-engine/docs/concepts/node-images for + // available image types. string image_type = 6 [(google.api.field_behavior) = REQUIRED]; // The name (project, location, cluster, node pool) of the node pool to @@ -3527,7 +3531,9 @@ message AutoprovisioningNodePoolDefaults { // https://cloud.google.com/compute/docs/disks/customer-managed-encryption string boot_disk_kms_key = 9; - // The image type to use for NAP created node. + // The image type to use for NAP created node. Please see + // https://cloud.google.com/kubernetes-engine/docs/concepts/node-images for + // available image types. string image_type = 10; } @@ -4596,7 +4602,8 @@ enum DatapathProvider { // Strategy used for node pool update. enum NodePoolUpdateStrategy { - // Default value. + // Default value if unset. GKE internally defaults the update strategy to + // SURGE for unspecified strategies. NODE_POOL_UPDATE_STRATEGY_UNSPECIFIED = 0; // blue-green upgrade. diff --git a/packages/google-container/protos/google/container/v1beta1/cluster_service.proto b/packages/google-container/protos/google/container/v1beta1/cluster_service.proto index 2bbbd5bcf19d..24922ac0a23a 100644 --- a/packages/google-container/protos/google/container/v1beta1/cluster_service.proto +++ b/packages/google-container/protos/google/container/v1beta1/cluster_service.proto @@ -676,7 +676,9 @@ message NodeConfig { map metadata = 4; // The image type to use for this node. Note that for a given image type, - // the latest version of it will be used. + // the latest version of it will be used. Please see + // https://cloud.google.com/kubernetes-engine/docs/concepts/node-images for + // available image types. string image_type = 5; // The map of Kubernetes labels (key/value pairs) to be applied to each node. @@ -2558,7 +2560,9 @@ message UpdateNodePoolRequest { // - "-": picks the Kubernetes master version string node_version = 5 [(google.api.field_behavior) = REQUIRED]; - // Required. The desired image type for the node pool. + // Required. The desired image type for the node pool. Please see + // https://cloud.google.com/kubernetes-engine/docs/concepts/node-images for + // available image types. string image_type = 6 [(google.api.field_behavior) = REQUIRED]; // The desired list of Google Compute Engine @@ -3876,7 +3880,9 @@ message AutoprovisioningNodePoolDefaults { // https://cloud.google.com/compute/docs/disks/customer-managed-encryption string boot_disk_kms_key = 9; - // The image type to use for NAP created node. + // The image type to use for NAP created node. Please see + // https://cloud.google.com/kubernetes-engine/docs/concepts/node-images for + // available image types. string image_type = 10; } @@ -4987,7 +4993,8 @@ message IdentityServiceConfig { // Strategy used for node pool update. enum NodePoolUpdateStrategy { - // Default value. + // Default value if unset. GKE internally defaults the update strategy to + // SURGE for unspecified strategies. NODE_POOL_UPDATE_STRATEGY_UNSPECIFIED = 0; // blue-green upgrade. diff --git a/packages/google-container/samples/generated/v1/cluster_manager.update_node_pool.js b/packages/google-container/samples/generated/v1/cluster_manager.update_node_pool.js index 49c673f51884..10715ac0d85c 100644 --- a/packages/google-container/samples/generated/v1/cluster_manager.update_node_pool.js +++ b/packages/google-container/samples/generated/v1/cluster_manager.update_node_pool.js @@ -41,7 +41,9 @@ function main(nodeVersion, imageType) { */ // const nodeVersion = 'abc123' /** - * Required. The desired image type for the node pool. + * Required. The desired image type for the node pool. Please see + * https://cloud.google.com/kubernetes-engine/docs/concepts/node-images for + * available image types. */ // const imageType = 'abc123' /** diff --git a/packages/google-container/samples/generated/v1/snippet_metadata.google.container.v1.json b/packages/google-container/samples/generated/v1/snippet_metadata.google.container.v1.json index 2ad2287804d5..f2a7a7754502 100644 --- a/packages/google-container/samples/generated/v1/snippet_metadata.google.container.v1.json +++ b/packages/google-container/samples/generated/v1/snippet_metadata.google.container.v1.json @@ -230,7 +230,7 @@ "segments": [ { "start": 25, - "end": 154, + "end": 156, "type": "FULL" } ], diff --git a/packages/google-container/samples/generated/v1beta1/cluster_manager.update_node_pool.js b/packages/google-container/samples/generated/v1beta1/cluster_manager.update_node_pool.js index fc69333ccee9..8f5b298a36ed 100644 --- a/packages/google-container/samples/generated/v1beta1/cluster_manager.update_node_pool.js +++ b/packages/google-container/samples/generated/v1beta1/cluster_manager.update_node_pool.js @@ -41,7 +41,9 @@ function main(projectId, zone, clusterId, nodePoolId, nodeVersion, imageType) { */ // const nodeVersion = 'abc123' /** - * Required. The desired image type for the node pool. + * Required. The desired image type for the node pool. Please see + * https://cloud.google.com/kubernetes-engine/docs/concepts/node-images for + * available image types. */ // const imageType = 'abc123' /** diff --git a/packages/google-container/samples/generated/v1beta1/snippet_metadata.google.container.v1beta1.json b/packages/google-container/samples/generated/v1beta1/snippet_metadata.google.container.v1beta1.json index d28a215f8165..5e0978cabf78 100644 --- a/packages/google-container/samples/generated/v1beta1/snippet_metadata.google.container.v1beta1.json +++ b/packages/google-container/samples/generated/v1beta1/snippet_metadata.google.container.v1beta1.json @@ -230,7 +230,7 @@ "segments": [ { "start": 25, - "end": 158, + "end": 160, "type": "FULL" } ], diff --git a/packages/google-container/src/v1/cluster_manager_client.ts b/packages/google-container/src/v1/cluster_manager_client.ts index d90a2e5b9467..8c52a823eb40 100644 --- a/packages/google-container/src/v1/cluster_manager_client.ts +++ b/packages/google-container/src/v1/cluster_manager_client.ts @@ -791,7 +791,9 @@ export class ClusterManagerClient { * - "1.X.Y-gke.N": picks an explicit Kubernetes version * - "-": picks the Kubernetes master version * @param {string} request.imageType - * Required. The desired image type for the node pool. + * Required. The desired image type for the node pool. Please see + * https://cloud.google.com/kubernetes-engine/docs/concepts/node-images for + * available image types. * @param {string} request.name * The name (project, location, cluster, node pool) of the node pool to * update. Specified in the format diff --git a/packages/google-container/src/v1beta1/cluster_manager_client.ts b/packages/google-container/src/v1beta1/cluster_manager_client.ts index 05d48525cec1..c5a3a28bbb9a 100644 --- a/packages/google-container/src/v1beta1/cluster_manager_client.ts +++ b/packages/google-container/src/v1beta1/cluster_manager_client.ts @@ -798,7 +798,9 @@ export class ClusterManagerClient { * - "1.X.Y-gke.N": picks an explicit Kubernetes version * - "-": picks the Kubernetes master version * @param {string} request.imageType - * Required. The desired image type for the node pool. + * Required. The desired image type for the node pool. Please see + * https://cloud.google.com/kubernetes-engine/docs/concepts/node-images for + * available image types. * @param {string[]} request.locations * The desired list of Google Compute Engine * [zones](https://cloud.google.com/compute/docs/zones#available) in which the