From b4cf7b0d961c663a09d0a4f8d11c6c0e8813e0c7 Mon Sep 17 00:00:00 2001 From: Gabe Pearhill Date: Mon, 4 May 2026 15:54:28 -0700 Subject: [PATCH 1/3] chore: remove unused system test from core/projectify --- .../.kokoro/continuous/node18/system-test.cfg | 12 ------------ core/projectify/system-test/.eslintrc.yml | 3 --- core/projectify/system-test/system.ts | 15 --------------- 3 files changed, 30 deletions(-) delete mode 100644 core/paginator/.kokoro/continuous/node18/system-test.cfg delete mode 100644 core/projectify/system-test/.eslintrc.yml delete mode 100644 core/projectify/system-test/system.ts diff --git a/core/paginator/.kokoro/continuous/node18/system-test.cfg b/core/paginator/.kokoro/continuous/node18/system-test.cfg deleted file mode 100644 index 4175c5b4d5c7..000000000000 --- a/core/paginator/.kokoro/continuous/node18/system-test.cfg +++ /dev/null @@ -1,12 +0,0 @@ -# Download resources for system tests (service account key, etc.) -gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/google-cloud-nodejs" - -env_vars: { - key: "TRAMPOLINE_BUILD_FILE" - value: "github/nodejs-paginator/core/paginator/.kokoro/system-test.sh" -} - -env_vars: { - key: "SECRET_MANAGER_KEYS" - value: "long-door-651-kokoro-system-test-service-account" -} \ No newline at end of file diff --git a/core/projectify/system-test/.eslintrc.yml b/core/projectify/system-test/.eslintrc.yml deleted file mode 100644 index 282535f55f6a..000000000000 --- a/core/projectify/system-test/.eslintrc.yml +++ /dev/null @@ -1,3 +0,0 @@ ---- -rules: - no-console: off diff --git a/core/projectify/system-test/system.ts b/core/projectify/system-test/system.ts deleted file mode 100644 index 05638eda311f..000000000000 --- a/core/projectify/system-test/system.ts +++ /dev/null @@ -1,15 +0,0 @@ -// Copyright 2018 Google LLC -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. - -console.warn('no system tests available 👻'); From 882093ccd10c8e599baac785d80a925506cb71bb Mon Sep 17 00:00:00 2001 From: Gabe Pearhill Date: Mon, 4 May 2026 16:01:26 -0700 Subject: [PATCH 2/3] whoops, deleted the wrong config file --- .../.kokoro/continuous}/node18/system-test.cfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename core/{projectify/.kokoro/presubmit => paginator/.kokoro/continuous}/node18/system-test.cfg (79%) diff --git a/core/projectify/.kokoro/presubmit/node18/system-test.cfg b/core/paginator/.kokoro/continuous/node18/system-test.cfg similarity index 79% rename from core/projectify/.kokoro/presubmit/node18/system-test.cfg rename to core/paginator/.kokoro/continuous/node18/system-test.cfg index 902859cf2d87..4175c5b4d5c7 100644 --- a/core/projectify/.kokoro/presubmit/node18/system-test.cfg +++ b/core/paginator/.kokoro/continuous/node18/system-test.cfg @@ -3,7 +3,7 @@ gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/google-cloud-nodejs" env_vars: { key: "TRAMPOLINE_BUILD_FILE" - value: "github/nodejs-projectify/core/projectify/.kokoro/system-test.sh" + value: "github/nodejs-paginator/core/paginator/.kokoro/system-test.sh" } env_vars: { From 610f79ea0eec9456ef55d5faeb751b84ab09bdce Mon Sep 17 00:00:00 2001 From: Gabe Pearhill Date: Mon, 4 May 2026 16:04:06 -0700 Subject: [PATCH 3/3] remove uneeded test script --- core/projectify/package.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/core/projectify/package.json b/core/projectify/package.json index adbff3f08ea6..9db0a09fb762 100644 --- a/core/projectify/package.json +++ b/core/projectify/package.json @@ -18,8 +18,7 @@ "prepare": "npm run compile", "pretest": "npm run compile", "docs": "jsdoc -c .jsdoc.js", - "presystem-test": "npm run compile", - "system-test": "mocha build/system-test", + "system-test": "echo 'no system test'", "docs-test": "linkinator docs", "predocs-test": "npm run docs", "precompile": "gts clean"