Skip to content

Commit 8d326d5

Browse files
Google APIscopybara-github
authored andcommitted
feat: Add encoding format to .google.cloud.security.privateca.v1.CaPool Resource
docs: A comment for field `maximum_lifetime` in message `.google.cloud.security.privateca.v1.CaPool` is changed docs: A comment for field `maximum_lifetime` in message `.google.cloud.security.privateca.v1.CertificateTemplate` is changed docs: A comment for field `subject_key_id` in message `.google.cloud.security.privateca.v1.CertificateConfig` is changed docs: A comment for method `FetchCaCerts` in service `CertificateAuthorityService` is changed docs: A comment for field `ignore_dependent_resources` in message `.google.cloud.security.privateca.v1.DisableCertificateAuthorityRequest` is changed docs: A comment for field `ignore_dependent_resources` in message `.google.cloud.security.privateca.v1.DeleteCertificateAuthorityRequest` is changed docs: A comment for field `ignore_dependent_resources` in message `.google.cloud.security.privateca.v1.DeleteCaPoolRequest` is changed docs: A comment for field `ca_certs` in message `.google.cloud.security.privateca.v1.FetchCaCertsResponse` is changed PiperOrigin-RevId: 620969058
1 parent 3644169 commit 8d326d5

2 files changed

Lines changed: 34 additions & 12 deletions

File tree

google/cloud/security/privateca/v1/resources.proto

Lines changed: 28 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -338,6 +338,22 @@ message CaPool {
338338
// [CertificateAuthority][google.cloud.security.privateca.v1.CertificateAuthority]
339339
// in the [CaPool][google.cloud.security.privateca.v1.CaPool].
340340
message PublishingOptions {
341+
// Supported encoding formats for publishing.
342+
enum EncodingFormat {
343+
// Not specified. By default, PEM format will be used.
344+
ENCODING_FORMAT_UNSPECIFIED = 0;
345+
346+
// The
347+
// [CertificateAuthority][google.cloud.security.privateca.v1.CertificateAuthority]'s
348+
// CA certificate and CRLs will be published in PEM format.
349+
PEM = 1;
350+
351+
// The
352+
// [CertificateAuthority][google.cloud.security.privateca.v1.CertificateAuthority]'s
353+
// CA certificate and CRLs will be published in DER format.
354+
DER = 2;
355+
}
356+
341357
// Optional. When true, publishes each
342358
// [CertificateAuthority][google.cloud.security.privateca.v1.CertificateAuthority]'s
343359
// CA certificate and includes its URL in the "Authority Information Access"
@@ -357,6 +373,12 @@ message CaPool {
357373
// days from their creation. However, we will rebuild daily. CRLs are also
358374
// rebuilt shortly after a certificate is revoked.
359375
bool publish_crl = 2 [(google.api.field_behavior) = OPTIONAL];
376+
377+
// Optional. Specifies the encoding format of each
378+
// [CertificateAuthority][google.cloud.security.privateca.v1.CertificateAuthority]
379+
// resource's CA certificate and CRLs. If this is omitted, CA certificates
380+
// and CRLs will be published in PEM.
381+
EncodingFormat encoding_format = 3 [(google.api.field_behavior) = OPTIONAL];
360382
}
361383

362384
// Defines controls over all certificate issuance within a
@@ -455,9 +477,9 @@ message CaPool {
455477
// if the issuing
456478
// [CertificateAuthority][google.cloud.security.privateca.v1.CertificateAuthority]
457479
// expires before a
458-
// [Certificate][google.cloud.security.privateca.v1.Certificate]'s requested
459-
// maximum_lifetime, the effective lifetime will be explicitly truncated to
460-
// match it.
480+
// [Certificate][google.cloud.security.privateca.v1.Certificate] resource's
481+
// requested maximum_lifetime, the effective lifetime will be explicitly
482+
// truncated to match it.
461483
google.protobuf.Duration maximum_lifetime = 2
462484
[(google.api.field_behavior) = OPTIONAL];
463485

@@ -773,7 +795,7 @@ message CertificateTemplate {
773795
// Optional. The maximum lifetime allowed for issued
774796
// [Certificates][google.cloud.security.privateca.v1.Certificate] that use
775797
// this template. If the issuing
776-
// [CaPool][google.cloud.security.privateca.v1.CaPool]'s
798+
// [CaPool][google.cloud.security.privateca.v1.CaPool] resource's
777799
// [IssuancePolicy][google.cloud.security.privateca.v1.CaPool.IssuancePolicy]
778800
// specifies a
779801
// [maximum_lifetime][google.cloud.security.privateca.v1.CaPool.IssuancePolicy.maximum_lifetime]
@@ -1062,8 +1084,8 @@ message CertificateConfig {
10621084

10631085
// Optional. When specified this provides a custom SKI to be used in the
10641086
// certificate. This should only be used to maintain a SKI of an existing CA
1065-
// originally created outside CAS, which was not generated using method (1)
1066-
// described in RFC 5280 section 4.2.1.2.
1087+
// originally created outside CA service, which was not generated using method
1088+
// (1) described in RFC 5280 section 4.2.1.2.
10671089
KeyId subject_key_id = 4 [(google.api.field_behavior) = OPTIONAL];
10681090
}
10691091

google/cloud/security/privateca/v1/service.proto

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,7 @@ service CertificateAuthorityService {
301301

302302
// FetchCaCerts returns the current trust anchor for the
303303
// [CaPool][google.cloud.security.privateca.v1.CaPool]. This will include CA
304-
// certificate chains for all Certificate Authorities in the ENABLED,
304+
// certificate chains for all certificate authorities in the ENABLED,
305305
// DISABLED, or STAGED states.
306306
rpc FetchCaCerts(FetchCaCertsRequest) returns (FetchCaCertsResponse) {
307307
option (google.api.http) = {
@@ -723,7 +723,7 @@ message DisableCertificateAuthorityRequest {
723723

724724
// Optional. This field allows this CA to be disabled even if it's being
725725
// depended on by another resource. However, doing so may result in unintended
726-
// and unrecoverable effects on any dependent resource(s) since the CA will
726+
// and unrecoverable effects on any dependent resources since the CA will
727727
// no longer be able to issue certificates.
728728
bool ignore_dependent_resources = 3 [(google.api.field_behavior) = OPTIONAL];
729729
}
@@ -910,9 +910,9 @@ message DeleteCertificateAuthorityRequest {
910910
// been allowed. If you proceed, there will be no way to recover this CA.
911911
bool skip_grace_period = 5 [(google.api.field_behavior) = OPTIONAL];
912912

913-
// Optional. This field allows this ca to be deleted even if it's being
913+
// Optional. This field allows this CA to be deleted even if it's being
914914
// depended on by another resource. However, doing so may result in unintended
915-
// and unrecoverable effects on any dependent resource(s) since the CA will
915+
// and unrecoverable effects on any dependent resources since the CA will
916916
// no longer be able to issue certificates.
917917
bool ignore_dependent_resources = 6 [(google.api.field_behavior) = OPTIONAL];
918918
}
@@ -1040,7 +1040,7 @@ message DeleteCaPoolRequest {
10401040

10411041
// Optional. This field allows this pool to be deleted even if it's being
10421042
// depended on by another resource. However, doing so may result in unintended
1043-
// and unrecoverable effects on any dependent resource(s) since the pool will
1043+
// and unrecoverable effects on any dependent resources since the pool will
10441044
// no longer be able to issue certificates.
10451045
bool ignore_dependent_resources = 4 [(google.api.field_behavior) = OPTIONAL];
10461046
}
@@ -1082,7 +1082,7 @@ message FetchCaCertsResponse {
10821082
repeated string certificates = 1;
10831083
}
10841084

1085-
// The PEM encoded CA certificate chains of all Certificate Authorities in
1085+
// The PEM encoded CA certificate chains of all certificate authorities in
10861086
// this [CaPool][google.cloud.security.privateca.v1.CaPool] in the ENABLED,
10871087
// DISABLED, or STAGED states.
10881088
repeated CertChain ca_certs = 1;

0 commit comments

Comments
 (0)