feat: use small HTTP dependency

Author: fhinkel

package.json

@@ -92,9 +92,9 @@
     "mime-types": "^2.0.8",
     "once": "^1.3.1",
     "pumpify": "^1.5.1",
-    "request": "^2.88.0",
     "snakeize": "^0.1.0",
     "stream-events": "^1.0.1",
+    "teeny-request": "^3.10.0",
     "through2": "^2.0.0",
     "xdg-basedir": "^3.0.0"
   },

src/bucket.ts

@@ -27,7 +27,8 @@ import * as is from 'is';
 import * as mime from 'mime-types';
 import * as path from 'path';
 const snakeize = require('snakeize');
-import * as request from 'request';
+import * as request from 'request';  // Only for type declarations.
+import {teenyRequest} from 'teeny-request';
 
 import {Acl} from './acl';
 import {Channel} from './channel';
@@ -702,7 +703,7 @@ class Bucket extends ServiceObject {
       id: name,
       createMethod: storage.createBucket.bind(storage),
       methods,
-      requestModule: request,
+      requestModule: teenyRequest as typeof request,
     });
 
     this.name = name;

src/channel.ts

@@ -18,7 +18,9 @@
 
 import {ServiceObject, util} from '@google-cloud/common';
 import {promisifyAll} from '@google-cloud/promisify';
-import * as request from 'request';
+import * as request from 'request';  // Only for type declarations.
+import {teenyRequest} from 'teeny-request';
+
 import {Storage} from '.';
 import {Response} from 'request';
 
@@ -31,6 +33,7 @@ export interface StopCallback {
   (err: Error|null, apiResponse?: request.Response): void;
 }
 
+
 /**
  * Create a channel object to interact with a Cloud Storage channel.
  *
@@ -60,7 +63,7 @@ class Channel extends ServiceObject {
       methods: {
           // Only need `request`.
       },
-      requestModule: request,
+      requestModule: teenyRequest as typeof request,
     };
 
     super(config);

src/file.ts

@@ -37,7 +37,9 @@ import * as through from 'through2';
 import * as xdgBasedir from 'xdg-basedir';
 import * as zlib from 'zlib';
 import * as url from 'url';
-import * as r from 'request';
+import * as r from 'request';  // Only for type declarations.
+import {teenyRequest} from 'teeny-request';
+
 
 import {Storage} from '.';
 import {Bucket} from './bucket';
@@ -273,7 +275,7 @@ class File extends ServiceObject {
       parent: bucket,
       baseUrl: '/o',
       id: encodeURIComponent(name),
-      requestModule: r,
+      requestModule: teenyRequest as typeof r,
     });
 
     this.bucket = bucket;
@@ -2630,7 +2632,7 @@ class File extends ServiceObject {
       },
       metadata: options.metadata,
       request: reqOpts,
-      requestModule: r,
+      requestModule: teenyRequest as typeof r,
     });
   }
 }

src/index.ts

@@ -21,7 +21,8 @@ import {Service, GoogleAuthOptions} from '@google-cloud/common';
 import {paginator} from '@google-cloud/paginator';
 import {promisifyAll} from '@google-cloud/promisify';
 import * as extend from 'extend';
-import * as request from 'request';
+import * as request from 'request';  // Only for type declarations.
+import {teenyRequest} from 'teeny-request';
 
 import {Bucket} from './bucket';
 import {Channel} from './channel';
@@ -256,7 +257,7 @@ class Storage extends Service {
         'https://www.googleapis.com/auth/devstorage.full_control',
       ],
       packageJson: require('../../package.json'),
-      requestModule: request,
+      requestModule: teenyRequest as typeof request,
     };
 
     super(config, options);

src/notification.ts

@@ -19,7 +19,9 @@
 import {ServiceObject, util, ApiError, GetMetadataCallback} from '@google-cloud/common';
 import {promisifyAll} from '@google-cloud/promisify';
 import * as is from 'is';
-import * as request from 'request';
+import * as request from 'request';  // Only for type declarations.
+import {teenyRequest} from 'teeny-request';
+
 import {Bucket} from './bucket';
 import {ResponseBody} from '@google-cloud/common/build/src/util';
 
@@ -88,6 +90,7 @@ export interface DeleteNotificationCallback {
   (err: Error|null, apiResponse?: request.Response): void;
 }
 
+
 /**
  * A Notification object is created from your {@link Bucket} object using
  * {@link Bucket#notification}. Use it to interact with Cloud Pub/Sub
@@ -191,7 +194,7 @@ class Notification extends ServiceObject {
       id: id.toString(),
       createMethod: bucket.createNotification.bind(bucket),
       methods,
-      requestModule: request,
+      requestModule: teenyRequest as typeof request,
     });
   }
 

system-test/storage.js

@@ -28,12 +28,11 @@ const path = require('path');
 const through = require('through2');
 const tmp = require('tmp');
 const uuid = require('uuid');
-
+const PubSub = require('@google-cloud/pubsub');
 const util = require('@google-cloud/common').util;
 
 const {Storage} = require('../');
 const Bucket = Storage.Bucket;
-const PubSub = require('@google-cloud/pubsub');
 
 describe('storage', function() {
   const USER_ACCOUNT = 'user-spsawchuk@gmail.com';