Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

Commit 5fd39ef

Browse files
gcf-owl-bot[bot]ddelgrosso1
authored andcommitted
chore(Node.js): Update PR Template
* feat: Update PR Template * docs: Update synthtool/gcp/templates/node_library/.github/PULL_REQUEST_TEMPLATE.md Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com> * docs: Update synthtool/gcp/templates/node_library/.github/PULL_REQUEST_TEMPLATE.md Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com> --------- Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com> Source-Link: googleapis/synthtool@bb0a350 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:d0befde9bb710526253d1badc2d5b02884b466acc99db4e26ce8e71e69072ea0
1 parent c1aa7d8 commit 5fd39ef

4 files changed

Lines changed: 34 additions & 10 deletions

File tree

.github/.OwlBot.lock.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright 2024 Google LLC
1+
# Copyright 2025 Google LLC
22
#
33
# Licensed under the Apache License, Version 2.0 (the "License");
44
# you may not use this file except in compliance with the License.
@@ -13,5 +13,5 @@
1313
# limitations under the License.
1414
docker:
1515
image: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest
16-
digest: sha256:22e41dd7cd82683fa338b647abcc3a29ddb1b17e800b089adc0bec0a3175312c
17-
# created: 2024-10-30T16:51:59.982020867Z
16+
digest: sha256:d0befde9bb710526253d1badc2d5b02884b466acc99db4e26ce8e71e69072ea0
17+
# created: 2025-03-07T03:28:55.703836867Z

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 28 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,30 @@
1-
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
2-
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/nodejs-storage/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
1+
> Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
2+
3+
## Description
4+
5+
> Please provide a detailed description for the change.
6+
> As much as possible, please try to keep changes separate by purpose. For example, try not to make a one-line bug fix in a feature request, or add an irrelevant README change to a bug fix.
7+
8+
## Impact
9+
10+
> What's the impact of this change?
11+
12+
## Testing
13+
14+
> Have you added unit and integration tests if necessary?
15+
> Were any tests changed? Are any breaking changes necessary?
16+
17+
## Additional Information
18+
19+
> Any additional details that we should be aware of?
20+
21+
## Checklist
22+
23+
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/nodejs-storage/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
324
- [ ] Ensure the tests and linter pass
4-
- [ ] Code coverage does not decrease (if any source code was changed)
5-
- [ ] Appropriate docs were updated (if necessary)
25+
- [ ] Code coverage does not decrease
26+
- [ ] Appropriate docs were updated
27+
- [ ] Appropriate comments were added, particularly in complex areas or places that require background
28+
- [ ] No new warnings or issues will be generated from this change
629

7-
Fixes #<issue_number_goes_here> 🦕
30+
Fixes #issue_number_goes_here 🦕

.github/workflows/ci.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,4 +46,3 @@ jobs:
4646
node-version: 18
4747
- run: npm install
4848
- run: npm run lint
49-

.kokoro/samples-test.sh

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)