Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

fix: encode name portion when calling publicUrl function#1828

Merged
shaffeeullah merged 2 commits intogoogleapis:mainfrom
ddelgrosso1:fix-public-url
Mar 28, 2022
Merged

fix: encode name portion when calling publicUrl function#1828
shaffeeullah merged 2 commits intogoogleapis:mainfrom
ddelgrosso1:fix-public-url

Conversation

@ddelgrosso1
Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1824 🦕

@ddelgrosso1 ddelgrosso1 requested review from a team March 28, 2022 15:02
@product-auto-label product-auto-label Bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Mar 28, 2022
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 28, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 28, 2022
@shaffeeullah shaffeeullah merged commit 5522b35 into googleapis:main Mar 28, 2022
@ddelgrosso1 ddelgrosso1 deleted the fix-public-url branch March 28, 2022 16:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/nodejs-storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File.publicUrl() returns an incorrect URL if the file key contains URL query parameters

2 participants