Skip to content
This repository was archived by the owner on Oct 17, 2023. It is now read-only.

Commit acea0a2

Browse files
JustinBeckwithstephenplusplus
authored andcommitted
Enable noImplicitThis in tsconfig (#115)
Resolves #69
1 parent 55c545a commit acea0a2

2 files changed

Lines changed: 9 additions & 6 deletions

File tree

test/index.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,12 @@ const fakeUtil = extend({}, util, {
4747
});
4848
const originalFakeUtil = extend(true, {}, fakeUtil);
4949

50-
function FakeService() {
51-
this.calledWith_ = arguments;
50+
class FakeService {
51+
calledWith_: IArguments;
52+
request?: Function;
53+
constructor() {
54+
this.calledWith_ = arguments;
55+
}
5256
}
5357

5458
describe('Translate', () => {
@@ -525,10 +529,10 @@ describe('Translate', () => {
525529

526530
describe('request', () => {
527531
describe('OAuth mode', () => {
528-
let request: r.Request;
532+
let request: Function;
529533

530534
beforeEach(() => {
531-
request = FakeService.prototype.request;
535+
request = FakeService.prototype.request!;
532536
});
533537

534538
afterEach(() => {

tsconfig.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@
22
"extends": "./node_modules/gts/tsconfig-google.json",
33
"compilerOptions": {
44
"rootDir": ".",
5-
"outDir": "build",
6-
"noImplicitThis": false
5+
"outDir": "build"
76
},
87
"include": [
98
"src/*.ts",

0 commit comments

Comments
 (0)