Skip to content

Commit 534536c

Browse files
feat(release-please): add default branch input option for github release (#206)
1 parent 61a3f25 commit 534536c

2 files changed

Lines changed: 25 additions & 7 deletions

File tree

index.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@ async function main () {
3636
monorepoTags,
3737
token,
3838
changelogPath,
39-
releaseType
39+
releaseType,
40+
defaultBranch
4041
})
4142
const releaseCreated = await gr.createRelease()
4243
if (releaseCreated) {

test/release-please.js

Lines changed: 23 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,17 @@ describe('release-please-action', () => {
2020
upload_url: 'http://example.com',
2121
tag_name: 'v1.0.0'
2222
})
23+
let ReleaseStub = sinon.stub()
2324
action.getGitHubRelease = () => {
24-
class Release {}
25-
Release.prototype.createRelease = createRelease
26-
return Release
25+
class Release {
26+
createRelease () {}
27+
}
28+
ReleaseStub = sinon.spy(function () {
29+
const instance = sinon.createStubInstance(Release)
30+
instance.createRelease = createRelease
31+
return instance
32+
})
33+
return ReleaseStub
2734
}
2835
const releasePR = sinon.stub().returns(25)
2936
const buildStatic = sinon.stub().returns({
@@ -36,6 +43,7 @@ describe('release-please-action', () => {
3643
}
3744
await action.main()
3845
sinon.assert.calledOnce(createRelease)
46+
sinon.assert.calledWith(ReleaseStub, sinon.match.hasOwn('defaultBranch', undefined))
3947
sinon.assert.calledWith(buildStatic, 'node', sinon.match.hasOwn('defaultBranch', undefined))
4048
sinon.assert.calledOnce(releasePR)
4149
assert.deepStrictEqual(output, {
@@ -62,10 +70,18 @@ describe('release-please-action', () => {
6270
upload_url: 'http://example.com',
6371
tag_name: 'v1.0.0'
6472
})
73+
74+
let ReleaseStub = sinon.stub()
6575
action.getGitHubRelease = () => {
66-
class Release {}
67-
Release.prototype.createRelease = createRelease
68-
return Release
76+
class Release {
77+
createRelease () {}
78+
}
79+
ReleaseStub = sinon.spy(function () {
80+
const instance = sinon.createStubInstance(Release)
81+
instance.createRelease = createRelease
82+
return instance
83+
})
84+
return ReleaseStub
6985
}
7086
const releasePR = sinon.stub().returns(25)
7187
const buildStatic = sinon.stub().returns({
@@ -78,6 +94,7 @@ describe('release-please-action', () => {
7894
}
7995
await action.main()
8096
sinon.assert.calledOnce(createRelease)
97+
sinon.assert.calledWith(ReleaseStub, sinon.match.hasOwn('defaultBranch', 'dev'))
8198
sinon.assert.calledWith(buildStatic, 'node', sinon.match.hasOwn('defaultBranch', 'dev'))
8299
sinon.assert.calledOnce(releasePR)
83100
assert.deepStrictEqual(output, {

0 commit comments

Comments
 (0)