fix(release-please): uses factory from latest version#222
Merged
bcoe merged 4 commits intogoogleapis:mainfrom Feb 15, 2021
Merged
fix(release-please): uses factory from latest version#222bcoe merged 4 commits intogoogleapis:mainfrom
bcoe merged 4 commits intogoogleapis:mainfrom
Conversation
Contributor
pragmaticivan
commented
Feb 14, 2021
pragmaticivan
commented
- uses factory from latest version
- use release-please@next
- fixes tests with factory usage
Contributor
Author
|
Tested it here: https://github.com/remoteday/rd-api/releases |
Contributor
Author
|
It's currently using release-please@next so if you want to merge it, I can just put the latest workable version in v10 so it would fix v2. |
bcoe
reviewed
Feb 15, 2021
bcoe
changed the title
bcoe
approved these changes
Feb 15, 2021
bcoe
left a comment
bcoe
left a comment
There was a problem hiding this comment.
Thanks for the fix 👍
I've already rolled back the v2 tag to the last good release, so it should be good (It's want created the open release PR for release-please).
I'm going to follow on with a couple additional tests before we release.
This was referenced Aug 22, 2022
This was referenced Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.