fix: get the correct boolean value of the input#233
Merged
bcoe merged 6 commits intogoogleapis:mainfrom Feb 17, 2021
Merged
Conversation
add getBooleanInput function to get the correct boolean value of the input fix googleapis#215
update the error with the wrong boolean input
Contributor
Author
|
@bcoe I find a bot will pull a request for build the dist, so I didn't run |
bcoe
suggested changes
Feb 16, 2021
bcoe
left a comment
bcoe
left a comment
There was a problem hiding this comment.
One nit about how we handle default value.
The default value is set in action.yml. use logical OR operator instead of the ternary operation. use logical AND operator instead of the paser of changelogTypes.
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
bcoe
approved these changes
Feb 17, 2021
|
@yi-Xu-0100 thank you for the contribution. |
This was referenced Aug 22, 2022
This was referenced Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #215