Skip to content

feat: add release_created per path in manifest PR#310

Merged
bcoe merged 6 commits intogoogleapis:mainfrom
phated:patch-1
Jun 25, 2021
Merged

feat: add release_created per path in manifest PR#310
bcoe merged 6 commits intogoogleapis:mainfrom
phated:patch-1

Conversation

@phated
Copy link
Copy Markdown
Contributor

@phated phated commented May 9, 2021

We were just implementing a release process on a vscode extension in our monorepo, and that has a separate release flow than anything else, so we'd only want the publish phase to run if a specific path was released.

This adds a release_created flag on each published package in a manifest release.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented May 9, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added the cla: no label May 9, 2021
@phated
Copy link
Copy Markdown
Contributor Author

phated commented May 9, 2021

I assume this commit was made with some github noreply email instead of the one I've signed the CLA with?

Comment thread index.js Outdated
@google-cla
Copy link
Copy Markdown

google-cla Bot commented May 13, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Jun 20, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Jun 20, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Jun 20, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@bcoe bcoe changed the title feat: Add release_created per path in manifest PR feat: add release_created per path in manifest PR Jun 20, 2021
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@bcoe
Copy link
Copy Markdown

bcoe commented Jun 20, 2021

@phated this looks ready to land to me, have you signed the CLA?

@phated
Copy link
Copy Markdown
Contributor Author

phated commented Jun 20, 2021

@bcoe thanks for fixing these tests! I think something is broken with the bot because when I log in, it says my CLA is signed.

@phated
Copy link
Copy Markdown
Contributor Author

phated commented Jun 21, 2021

@googlebot I signed it!

@phated
Copy link
Copy Markdown
Contributor Author

phated commented Jun 21, 2021

@bcoe could the issue be that I use a dot in my email for all my git commits, but google has it down as 1 word (that's how it shows when I log in)?

@bcoe bcoe added cla: yes and removed cla: no labels Jun 21, 2021
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Jun 21, 2021

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Jun 21, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added cla: no and removed cla: yes labels Jun 21, 2021
@bcoe bcoe added cla: yes and removed cla: no labels Jun 25, 2021
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Jun 25, 2021

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants