Skip to content

feat(release-please): update to release-please with rust mono-repo support#327

Merged
bcoe merged 1 commit intomainfrom
release-please-rust-manifest
Jul 28, 2021
Merged

feat(release-please): update to release-please with rust mono-repo support#327
bcoe merged 1 commit intomainfrom
release-please-rust-manifest

Conversation

@bcoe
Copy link
Copy Markdown

@bcoe bcoe commented Jul 14, 2021

@fasterthanlime any other changes that you think we'll need other than using the latest release?

@google-cla google-cla Bot added the cla: yes label Jul 14, 2021
@fasterthanlime
Copy link
Copy Markdown

any other changes that you think we'll need other than using the latest release?

I don't think my PR added any additional user-facing options. skipDependencyUpdates (née forManifestReleaser) should be entirely inernal - it's been a hot second since I've looked at how release-please-action uses the release-please API (we've moved away from GH Actions so we use the CLI directly on another CI) but I think we should be in the clear.

I can take some time to set up a test repo tomorrow with the latest release-please-action and report back to see if everything's working as intended, if that'd be helpful?

@bcoe
Copy link
Copy Markdown
Author

bcoe commented Jul 14, 2021

@fasterthanlime as long as things are working for you, don't test the action unless you have a good reason, we can always debug if another user starts experimenting.

@fasterthanlime
Copy link
Copy Markdown

Sounds good! It's been working great for us since the final changes to the PR — I may have gone a little update happy to test it in purpose 😬 it was very satisfying to see 13 releases done with a single PR! It made our team happy and other teams interested in the manifest releaser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants