fix: default package-name to undefined#459
Merged
bcoe merged 2 commits intogoogleapis:mainfrom Apr 20, 2022
lukekarrys:lk/package-name-undefined
Merged
fix: default package-name to undefined#459bcoe merged 2 commits intogoogleapis:mainfrom lukekarrys:lk/package-name-undefined
package-name to undefined#459bcoe merged 2 commits intogoogleapis:mainfrom
lukekarrys:lk/package-name-undefined
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
This allows for release-please to fallback to the deault value since it uses the nullish coalescing operator for that check. Fixes #457
bcoe
approved these changes
Apr 20, 2022
bcoe
approved these changes
Apr 20, 2022
|
@lukekarrys thanks for the contribution 👏 |
This was referenced Aug 22, 2022
This was referenced Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for release-please to fallback to the default value since it
uses the nullish coalescing operator for that check.
Fixes #457