feat: read github api/graphql url from action context#532
Merged
chingor13 merged 4 commits intogoogleapis:mainfrom Aug 10, 2022
Merged
feat: read github api/graphql url from action context#532chingor13 merged 4 commits intogoogleapis:mainfrom
chingor13 merged 4 commits intogoogleapis:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
goatwu1993
force-pushed
the
ci/try-to-use-github-context
branch
from
f57c785 to
420ee2d
Compare
goatwu1993
changed the title
Contributor
Author
|
Works on my site. |
Contributor
Author
|
@chingor13 please take a look. |
chingor13
requested changes
Aug 10, 2022
Contributor
chingor13
left a comment
chingor13
left a comment
There was a problem hiding this comment.
This looks good, except the tests are failing.
Looks like core.getInput() returns undefined if not set
chingor13
approved these changes
Aug 10, 2022
This was referenced Aug 15, 2022
Closed
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #508
This allowed GitHub Enterprise users to use this action without specifying github-api-url and github-graphql-url