fix(cargo-workspace): stop defaulting to updating all components (#1414)

* test: add failing test for not updating unnecessary components

* fix(cargo-workspace): stop default to updating all components

Author: chingor13

__snapshots__/cargo-workspace.js

@@ -27,13 +27,6 @@ Release notes for path: packages/rustA, releaseType: rust
     * pkgB bumped from 2.2.2 to 2.2.3
 </details>
 
-<details><summary>pkgD: 1.2.4</summary>
-
-### Dependencies
-
-
-</details>
-
 ---
 This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
 `
@@ -71,6 +64,29 @@ Release notes for path: packages/rustA, releaseType: rust
 This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
 `
 
+exports['CargoWorkspace plugin run skips component if not touched 1'] = `
+:robot: I have created a release *beep* *boop*
+---
+
+
+<details><summary>pkgB: 2.3.0</summary>
+
+Release notes for path: packages/rustB, releaseType: rust
+</details>
+
+<details><summary>pkgC: 3.3.4</summary>
+
+### Dependencies
+
+* The following workspace dependencies were updated
+  * dependencies
+    * pkgB bumped from 2.2.2 to 2.3.0
+</details>
+
+---
+This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
+`
+
 exports['CargoWorkspace plugin run walks dependency tree and updates previously untouched packages 1'] = `
 :robot: I have created a release *beep* *boop*
 ---

src/plugins/cargo-workspace.ts

@@ -12,26 +12,16 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-import {
-  CandidateReleasePullRequest,
-  RepositoryConfig,
-  ROOT_PROJECT_PATH,
-} from '../manifest';
+import {CandidateReleasePullRequest, ROOT_PROJECT_PATH} from '../manifest';
 import {logger} from '../util/logger';
-import {
-  WorkspacePlugin,
-  DependencyGraph,
-  DependencyNode,
-  WorkspacePluginOptions,
-} from './workspace';
+import {WorkspacePlugin, DependencyGraph, DependencyNode} from './workspace';
 import {
   CargoManifest,
   parseCargoManifest,
   CargoDependencies,
   CargoDependency,
 } from '../updaters/rust/common';
 import {VersionsMap, Version} from '../version';
-import {GitHub} from '../github';
 import {CargoToml} from '../updaters/rust/cargo-toml';
 import {RawContent} from '../updaters/raw-content';
 import {Changelog} from '../updaters/changelog';
@@ -82,17 +72,6 @@ interface CrateInfo {
  * into a single rust package.
  */
 export class CargoWorkspace extends WorkspacePlugin<CrateInfo> {
-  constructor(
-    github: GitHub,
-    targetBranch: string,
-    repositoryConfig: RepositoryConfig,
-    options: WorkspacePluginOptions = {}
-  ) {
-    super(github, targetBranch, repositoryConfig, {
-      ...options,
-      updateAllPackages: true,
-    });
-  }
   protected async buildAllPackages(
     candidates: CandidateReleasePullRequest[]
   ): Promise<{

src/plugins/workspace.ts

@@ -277,6 +277,10 @@ export abstract class WorkspacePlugin<T> extends ManifestPlugin {
     graph: DependencyGraph<T>,
     packageNamesToUpdate: string[]
   ): T[] {
+    logger.info(
+      `building graph order, existing package names: ${packageNamesToUpdate}`
+    );
+
     // invert the graph so it's dependency name => packages that depend on it
     const dependentGraph = this.invertGraph(graph);
     const visited: Set<T> = new Set();

test/plugins/cargo-workspace.ts

@@ -23,6 +23,7 @@ import {
   assertHasUpdate,
   dateSafe,
   stubFilesFromFixtures,
+  assertNoHasUpdate,
 } from '../helpers';
 import {Version} from '../../src/version';
 import {ManifestPlugin} from '../../src/plugin';
@@ -300,7 +301,47 @@ describe('CargoWorkspace plugin', () => {
       assertHasUpdate(updates, 'packages/rustA/Cargo.toml', RawContent);
       assertHasUpdate(updates, 'packages/rustB/Cargo.toml', RawContent);
       assertHasUpdate(updates, 'packages/rustC/Cargo.toml', RawContent);
-      assertHasUpdate(updates, 'packages/rustD/Cargo.toml', RawContent);
+      snapshot(dateSafe(rustCandidate!.pullRequest.body.toString()));
+    });
+    it('skips component if not touched', async () => {
+      const candidates: CandidateReleasePullRequest[] = [
+        buildMockCandidatePullRequest(
+          'packages/rustB',
+          'rust',
+          '2.3.0',
+          'pkgB',
+          [
+            buildMockPackageUpdate(
+              'packages/rustB/Cargo.toml',
+              'packages/rustB/Cargo.toml'
+            ),
+          ]
+        ),
+      ];
+      stubFilesFromFixtures({
+        sandbox,
+        github,
+        fixturePath: fixturesPath,
+        files: [
+          'Cargo.toml',
+          'packages/rustA/Cargo.toml',
+          'packages/rustB/Cargo.toml',
+          'packages/rustC/Cargo.toml',
+          'packages/rustD/Cargo.toml',
+        ],
+        flatten: false,
+        targetBranch: 'main',
+      });
+      const newCandidates = await plugin.run(candidates);
+      expect(newCandidates).lengthOf(1);
+      const rustCandidate = newCandidates.find(
+        candidate => candidate.config.releaseType === 'rust'
+      );
+      expect(rustCandidate).to.not.be.undefined;
+      const updates = rustCandidate!.pullRequest.updates;
+      // pkgA is not touched and does not have a dependency on pkgB
+      assertNoHasUpdate(updates, 'packages/rustA/Cargo.toml');
+      assertHasUpdate(updates, 'packages/rustB/Cargo.toml', RawContent);
       snapshot(dateSafe(rustCandidate!.pullRequest.body.toString()));
     });
   });