Skip to content

Commit 5a50247

Browse files
authored
feat!: require node 18+ (#2069)
1 parent 3df82e3 commit 5a50247

2 files changed

Lines changed: 3 additions & 8 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,12 @@ jobs:
99
runs-on: ubuntu-latest
1010
strategy:
1111
matrix:
12-
node: [14, 16, 18]
12+
node: [18, 20]
1313
steps:
1414
- uses: actions/checkout@v4
1515
- uses: actions/setup-node@v3
1616
with:
1717
node-version: ${{ matrix.node }}
18-
- name: Override NODE options for the most recent version
19-
if: matrix.node == '18'
20-
run: echo "NODE_OPTIONS=--no-experimental-fetch" >> $GITHUB_ENV
2118
- run: node --version
2219
# The first installation step ensures that all of our production
2320
# dependencies work on the given Node.js version, this helps us find
@@ -36,8 +33,6 @@ jobs:
3633
- uses: actions/setup-node@v3
3734
with:
3835
node-version: 18
39-
- name: Override NODE options for the most recent version
40-
run: echo "NODE_OPTIONS=--no-experimental-fetch" >> $env:GITHUB_ENV
4136
- run: npm install
4237
- run: npm test
4338
env:

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"main": "./build/src/index.js",
66
"bin": "./build/src/bin/release-please.js",
77
"scripts": {
8-
"test": "cross-env ENVIRONMENT=test LC_ALL=en c8 mocha --recursive --timeout=5000 build/test",
8+
"test": "cross-env ENVIRONMENT=test LC_ALL=en c8 mocha --node-option no-experimental-fetch --recursive --timeout=5000 build/test",
99
"docs": "echo add docs tests",
1010
"test:snap": "SNAPSHOT_UPDATE=1 LC_ALL=en npm test",
1111
"clean": "gts clean",
@@ -104,6 +104,6 @@
104104
"yargs": "^17.0.0"
105105
},
106106
"engines": {
107-
"node": ">=14.0.0"
107+
"node": ">=18.0.0"
108108
}
109109
}

0 commit comments

Comments
 (0)