feat: add support for yarn workspace versions (#1819)

* feat: add support for yarn workspace versions

* fix: workspace condition to cover edge cases

Co-authored-by: Jeff Ching <chingor@google.com>

Author: mpetrunic

__snapshots__/node-workspace.js

@@ -27,6 +27,15 @@ Release notes for path: node1, releaseType: node
     * @here/pkgB bumped from 2.2.2 to 2.2.3
 </details>
 
+<details><summary>@here/pkgE: 1.0.1</summary>
+
+### Dependencies
+
+* The following workspace dependencies were updated
+  * dependencies
+    * @here/pkgA bumped to 3.3.4
+</details>
+
 ---
 This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
 `
@@ -155,6 +164,15 @@ Release notes for path: node1, releaseType: node
 Release notes for path: node4, releaseType: node
 </details>
 
+<details><summary>@here/pkgE: 1.0.1</summary>
+
+### Dependencies
+
+* The following workspace dependencies were updated
+  * dependencies
+    * @here/pkgA bumped to 3.3.4
+</details>
+
 ---
 This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
 `

package.json

@@ -44,10 +44,10 @@
     "@types/iarna__toml": "^2.0.1",
     "@types/js-yaml": "^4.0.0",
     "@types/jsonpath": "^0.2.0",
-    "@types/lerna__collect-updates": "^5.0.0",
-    "@types/lerna__package": "^5.0.0",
-    "@types/lerna__package-graph": "^5.0.0",
-    "@types/lerna__run-topologically": "^5.0.0",
+    "@types/lerna__collect-updates": "^5.1.0",
+    "@types/lerna__package": "^5.1.0",
+    "@types/lerna__package-graph": "^5.1.0",
+    "@types/lerna__run-topologically": "^5.1.0",
     "@types/mocha": "^9.0.0",
     "@types/node": "^18.0.0",
     "@types/pino": "^7.0.0",
@@ -70,10 +70,10 @@
     "@conventional-commits/parser": "^0.4.1",
     "@google-automations/git-file-utils": "^1.2.5",
     "@iarna/toml": "^2.2.5",
-    "@lerna/collect-updates": "^4.0.0",
-    "@lerna/package": "^4.0.0",
-    "@lerna/package-graph": "^4.0.0",
-    "@lerna/run-topologically": "^4.0.0",
+    "@lerna/collect-updates": "^6.4.1",
+    "@lerna/package": "^6.4.1",
+    "@lerna/package-graph": "^6.4.1",
+    "@lerna/run-topologically": "^6.4.1",
     "@octokit/graphql": "^5.0.0",
     "@octokit/request": "^6.0.0",
     "@octokit/request-error": "^3.0.0",

src/plugins/node-workspace.ts

@@ -181,7 +181,11 @@ export class NodeWorkspace extends WorkspacePlugin<Package> {
         );
       }
     }
-    const dependencyNotes = getChangelogDepsNotes(pkg, updatedPackage);
+    const dependencyNotes = getChangelogDepsNotes(
+      pkg,
+      updatedPackage,
+      updatedVersions
+    );
     existingCandidate.pullRequest.updates =
       existingCandidate.pullRequest.updates.map(update => {
         if (update.path === addPath(existingCandidate.path, 'package.json')) {
@@ -256,7 +260,11 @@ export class NodeWorkspace extends WorkspacePlugin<Package> {
         );
       }
     }
-    const dependencyNotes = getChangelogDepsNotes(pkg, updatedPackage);
+    const dependencyNotes = getChangelogDepsNotes(
+      pkg,
+      updatedPackage,
+      updatedVersions
+    );
     const packageJson = updatedPackage.toJSON() as PackageJson;
     const version = Version.parse(packageJson.version);
     const pullRequest: ReleasePullRequest = {
@@ -374,7 +382,11 @@ enum SUPPORTED_RANGE_PREFIXES {
   EQUAL_OR_LESS_THAN = '<=',
 }
 
-function getChangelogDepsNotes(original: Package, updated: Package): string {
+function getChangelogDepsNotes(
+  original: Package,
+  updated: Package,
+  updateVersions: VersionsMap
+): string {
   let depUpdateNotes = '';
   type DT =
     | 'dependencies'
@@ -400,6 +412,16 @@ function getChangelogDepsNotes(original: Package, updated: Package): string {
         depUpdates.push(
           `\n    * ${depName} bumped from ${origDepVer} to ${currentDepVer}`
         );
+        //handle case when "workspace:" version is used
+      } else if (
+        currentDepVer.startsWith('workspace:') &&
+        updateVersions.get(depName) !== undefined
+      ) {
+        depUpdates.push(
+          `\n    * ${depName} bumped to ${updateVersions
+            .get(depName)
+            ?.toString()}`
+        );
       }
     }
     if (depUpdates.length > 0) {

test/fixtures/plugins/node-workspace/node5/package.json

@@ -0,0 +1,8 @@
+{
+  "name": "@here/pkgE",
+  "version": "1.0.0",
+  "dependencies": {
+    "@here/pkgA": "workspace:^",
+    "anotherExternal": "^4.3.1"
+  }
+}

test/plugins/node-workspace.ts

@@ -102,6 +102,9 @@ describe('NodeWorkspace plugin', () => {
       node4: {
         releaseType: 'node',
       },
+      node5: {
+        releaseType: 'node',
+      },
     });
   });
   afterEach(() => {
@@ -256,6 +259,7 @@ describe('NodeWorkspace plugin', () => {
           'node2/package.json',
           'node3/package.json',
           'node4/package.json',
+          'node5/package.json',
         ],
         flatten: false,
         targetBranch: 'main',
@@ -283,13 +287,18 @@ describe('NodeWorkspace plugin', () => {
         assertHasUpdate(updates, 'node4/package.json', RawContent),
         '4.4.5'
       );
+      assertHasVersionUpdate(
+        assertHasUpdate(updates, 'node5/package.json', RawContent),
+        '1.0.1'
+      );
       const updater = assertHasUpdate(
         updates,
         '.release-please-manifest.json',
         ReleasePleaseManifest
       ).updater as ReleasePleaseManifest;
       expect(updater.versionsMap?.get('node2')?.toString()).to.eql('2.2.3');
       expect(updater.versionsMap?.get('node3')?.toString()).to.eql('1.1.2');
+      expect(updater.versionsMap?.get('node5')?.toString()).to.eql('1.0.1');
       snapshot(dateSafe(nodeCandidate!.pullRequest.body.toString()));
     });
     it('appends dependency notes to an updated module', async () => {
@@ -329,6 +338,7 @@ describe('NodeWorkspace plugin', () => {
           'node2/package.json',
           'node3/package.json',
           'node4/package.json',
+          'node5/package.json',
         ],
         flatten: false,
         targetBranch: 'main',