feat(maven-workspace): update all discovered pom.xml within the components (#1667)

* feat(maven-workspace): can update any discovered pom.xml within the repository

* fix: load new plugin option from manifest

* docs: add comments for new helper methods

* fix: fetch pom.xml content

* fix: snapshot versioning bumps

* build: restore c8 test coverage

* fix merge conflict and tests

* docs: add a description of what FAKE_COMMIT is used for

* fix: default considerAllArtifacts to true

* docs: update docs for new default value

Author: chingor13

__snapshots__/maven-workspace.js

@@ -44,6 +44,70 @@ Release notes for path: maven3, releaseType: maven
 This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
 `
 
+exports['MavenWorkspace plugin run can consider all artifacts 1'] = `
+:robot: I have created a release *beep* *boop*
+---
+
+
+<details><summary>multi1: 1.1.2</summary>
+
+Release notes for path: multi1, releaseType: java-yoshi
+</details>
+
+<details><summary>com.google.example:my-bom: 1.2.4</summary>
+
+### Dependencies
+
+* The following workspace dependencies were updated
+    * com.google.example:multi1-bom bumped to 1.1.2,
+    * com.google.example:multi1-sub1 bumped to 2.2.3,
+    * com.google.example:multi1-sub2 bumped to 3.3.4
+</details>
+
+---
+This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
+`
+
+exports['MavenWorkspace plugin run can consider all artifacts 2'] = `
+<?xml version="1.0" encoding="UTF-8"?>
+<project>
+  <groupId>com.google.example</groupId>
+  <artifactId>my-bom</artifactId>
+  <version>1.2.4</version>
+  <dependencyManagement>
+    <dependencies>
+      <dependency>
+        <groupId>com.google.example</groupId>
+        <artifactId>multi1-bom</artifactId>
+        <version>1.1.2</version>
+        <type>pom</type>
+        <scope>import</scope>
+      </dependency>
+      <dependency>
+        <groupId>com.google.example</groupId>
+        <artifactId>multi1-sub1</artifactId>
+        <version>2.2.3</version>
+      </dependency>
+      <dependency>
+        <groupId>com.google.example</groupId>
+        <artifactId>multi1-sub2</artifactId>
+        <version>3.3.4</version>
+      </dependency>
+      <dependency>
+        <groupId>com.google.example</groupId>
+        <artifactId>multi2-sub1</artifactId>
+        <version>5.5.5</version>
+      </dependency>
+      <dependency>
+        <groupId>com.google.example</groupId>
+        <artifactId>multi2-sub2</artifactId>
+        <version>6.6.6</version>
+      </dependency>
+    </dependencies>
+  </dependencyManagement>
+</project>
+`
+
 exports['MavenWorkspace plugin run handles a single maven package 1'] = `
 :robot: I have created a release *beep* *boop*
 ---

docs/manifest-releaser.md

@@ -478,8 +478,13 @@ way of managing a Rust monorepo with release-please.
 
 The `maven-workspace` plugin operates similarly to the `node-workspace` plugin,
 but on a multi-artifact Maven workspace. It builds a dependency graph of all
-discovered `pom.xml` files that are configured in the manifest config and updates
-any packages that were directly bumped by release-please.
+discovered `pom.xml` files and updates any packages that were directly bumped
+by release-please.
+
+If you have additional `pom.xml` files that are not directly configured in your
+manifest and you want to skip updating them, then you can set the
+`considerAllArtifacts` option to `false`. If you do so, the plugin will only
+look at the `pom.xml` files configured in the manifest.
 
 ### linked-versions
 

schemas/config.json

@@ -292,6 +292,10 @@
                   "merge": {
                     "description": "Whether to merge in-scope pull requests into a combined release pull request. Defaults to `true`.",
                     "type": "boolean"
+                  },
+                  "considerAllArtifacts": {
+                    "description": "Whether to analyze all packages in the workspace for cross-component version bumping. This currently only works for the maven-workspace plugin. Defaults to `true`.",
+                    "type": "boolean"
                   }
                 }
               },

src/factories/plugin-factory.ts

@@ -29,6 +29,8 @@ import {MavenWorkspace} from '../plugins/maven-workspace';
 import {ConfigurationError} from '../errors';
 import {SentenceCase} from '../plugins/sentence-case';
 import {GroupPriority} from '../plugins/group-priority';
+import {Logger} from '../util/logger';
+import {WorkspacePluginOptions} from '../plugins/workspace';
 
 export interface PluginFactoryOptions {
   type: PluginType;
@@ -42,6 +44,9 @@ export interface PluginFactoryOptions {
 
   // workspace options
   updateAllPackages?: boolean;
+  considerAllArtifacts?: boolean;
+
+  logger?: Logger;
 }
 
 export type PluginBuilder = (options: PluginFactoryOptions) => ManifestPlugin;
@@ -60,21 +65,30 @@ const pluginFactories: Record<string, PluginBuilder> = {
       options.github,
       options.targetBranch,
       options.repositoryConfig,
-      options
+      {
+        ...options,
+        ...(options.type as WorkspacePluginOptions),
+      }
     ),
   'node-workspace': options =>
     new NodeWorkspace(
       options.github,
       options.targetBranch,
       options.repositoryConfig,
-      options
+      {
+        ...options,
+        ...(options.type as WorkspacePluginOptions),
+      }
     ),
   'maven-workspace': options =>
     new MavenWorkspace(
       options.github,
       options.targetBranch,
       options.repositoryConfig,
-      options
+      {
+        ...options,
+        ...(options.type as WorkspacePluginOptions),
+      }
     ),
   'sentence-case': options =>
     new SentenceCase(

src/manifest.ts

@@ -202,6 +202,7 @@ export interface SentenceCasePluginConfig extends ConfigurablePluginType {
 }
 export interface WorkspacePluginConfig extends ConfigurablePluginType {
   merge?: boolean;
+  considerAllArtifacts?: boolean;
 }
 export interface GroupPriorityPluginConfig extends ConfigurablePluginType {
   groups: string[];