fix: allow overlapping paths when splitting commits (#1733)

* test: failing test for supporting nested components

* fix: allow overlapping paths when splitting commits

* warning is no longer necessary

Author: chingor13

src/util/commit-split.ts

@@ -69,21 +69,14 @@ export class CommitSplit {
         newPath = newPath.replace(/^\//, '');
         newPath = newPath.replace(/$/, '/');
         newPath = newPath.replace(/^/, '/');
-        for (let exPath of paths) {
-          exPath = exPath.replace(/$/, '/');
-          exPath = exPath.replace(/^/, '/');
-          if (newPath.startsWith(exPath) || exPath.startsWith(newPath)) {
-            throw new Error(
-              `Path prefixes must be unique: ${newPath}, ${exPath}`
-            );
-          }
-        }
         // store them with leading and trailing slashes removed.
         newPath = newPath.replace(/\/$/, '');
         newPath = newPath.replace(/^\//, '');
         paths.push(newPath);
       }
-      this.packagePaths = paths;
+
+      // sort by longest paths first
+      this.packagePaths = paths.sort((a, b) => b.length - a.length);
     }
   }
 

test/util/commit-split.ts

@@ -56,6 +56,26 @@ describe('CommitSplit', () => {
     expect(splitCommits['pkg5']).lengthOf(1);
     expect(splitCommits['pkg6/pkg5']).lengthOf(1);
   });
+  it('handles nested folders', () => {
+    const commits: Commit[] = [
+      {
+        sha: 'abc123',
+        message: 'commit abc123',
+        files: ['core/foo.txt', 'pkg2/bar.txt'],
+      },
+      {
+        sha: 'def234',
+        message: 'commit def234',
+        files: ['core/subpackage/foo2.txt', 'pkg3/asdf.txt'],
+      },
+    ];
+    const commitSplit = new CommitSplit({
+      packagePaths: ['core', 'core/subpackage'],
+    });
+    const splitCommits = commitSplit.split(commits);
+    expect(splitCommits['core']).lengthOf(1);
+    expect(splitCommits['core/subpackage']).lengthOf(1);
+  });
   describe('including empty commits', () => {
     it('should separate commits', () => {
       const commitSplit = new CommitSplit({