Skip to content

Commit ef1c156

Browse files
authored
feat: extract and return the created release id (#1719)
Fixes #1645
1 parent a71ec7a commit ef1c156

7 files changed

Lines changed: 102 additions & 17 deletions

File tree

src/github.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,7 @@ export interface ReleaseOptions {
174174
}
175175

176176
export interface GitHubRelease {
177+
id: number;
177178
name?: string;
178179
tagName: string;
179180
sha: string;
@@ -1362,6 +1363,7 @@ export class GitHub {
13621363
target_commitish: release.sha,
13631364
});
13641365
return {
1366+
id: resp.data.id,
13651367
name: resp.data.name || undefined,
13661368
tagName: resp.data.tag_name,
13671369
sha: resp.data.target_commitish,

src/manifest.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,7 @@ const DEFAULT_COMMIT_SEARCH_DEPTH = 500;
252252
export const MANIFEST_PULL_REQUEST_TITLE_PATTERN = 'chore: release ${branch}';
253253

254254
interface CreatedRelease extends GitHubRelease {
255+
id: number;
255256
path: string;
256257
version: string;
257258
major: number;

test/cli.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -358,6 +358,7 @@ describe('CLI', () => {
358358
.stub(fakeManifest, 'createReleases')
359359
.resolves([
360360
{
361+
id: 123456,
361362
tagName: 'v1.2.3',
362363
sha: 'abc123',
363364
notes: 'some release notes',
@@ -1141,6 +1142,7 @@ describe('CLI', () => {
11411142
.stub(fakeManifest, 'createReleases')
11421143
.resolves([
11431144
{
1145+
id: 123456,
11441146
tagName: 'v1.2.3',
11451147
sha: 'abc123',
11461148
notes: 'some release notes',
@@ -1314,6 +1316,7 @@ describe('CLI', () => {
13141316
.stub(fakeManifest, 'createReleases')
13151317
.resolves([
13161318
{
1319+
id: 123456,
13171320
tagName: 'v1.2.3',
13181321
sha: 'abc123',
13191322
notes: 'some release notes',

test/github.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -684,6 +684,7 @@ describe('GitHub', () => {
684684
return true;
685685
})
686686
.reply(200, {
687+
id: 123456,
687688
tag_name: 'v1.2.3',
688689
draft: false,
689690
html_url: 'https://github.com/fake/fake/releases/v1.2.3',
@@ -709,6 +710,7 @@ describe('GitHub', () => {
709710
prerelease: false,
710711
});
711712
expect(release).to.not.be.undefined;
713+
expect(release.id).to.eql(123456);
712714
expect(release.tagName).to.eql('v1.2.3');
713715
expect(release.sha).to.eql('abc123');
714716
expect(release.draft).to.be.false;
@@ -825,6 +827,7 @@ describe('GitHub', () => {
825827
return true;
826828
})
827829
.reply(200, {
830+
id: 123456,
828831
tag_name: 'v1.2.3',
829832
draft: false,
830833
html_url: 'https://github.com/fake/fake/releases/v1.2.3',
@@ -851,6 +854,7 @@ describe('GitHub', () => {
851854
draft: false,
852855
prerelease: true,
853856
});
857+
expect(release.id).to.eql(123456);
854858
expect(release.tagName).to.eql('v1.2.3');
855859
expect(release.sha).to.eql('abc123');
856860
expect(release.draft).to.be.false;

0 commit comments

Comments
 (0)