fix(dart): add multiline flag to replace regex (#1524)

The dart `pubspec.yaml` is updated here with regex, and the file contains newlines. To properly match the replacement, the `/m` flag is needed for multiline match and replace. Prior to this fix, `pubspec.yaml` was never updated with the dart strategy.

Fixes #1523

Author: radicand

__snapshots__/pubspec-yaml.js

@@ -1,9 +1,21 @@
+exports['PubspecYaml updateContent leaves malformatted build numbers alone in pubspec.yaml file 1'] = `
+name: hello_world
+description: Hello World
+publish_to: 'none' # Remove this line if you wish to publish to pub.dev
+
+version: 0.6.0+abc
+
+environment:
+  sdk: '>=2.12.0 <3.0.0'
+
+`
+
 exports['PubspecYaml updateContent updates version in pubspec.yaml file 1'] = `
 name: hello_world
 description: Hello World
 publish_to: 'none' # Remove this line if you wish to publish to pub.dev
 
-version: 0.5.0
+version: 0.6.0
 
 environment:
   sdk: '>=2.12.0 <3.0.0'
@@ -15,7 +27,7 @@ name: hello_world
 description: Hello World
 publish_to: 'none' # Remove this line if you wish to publish to pub.dev
 
-version: 0.5.0+12
+version: 0.6.0+13
 
 environment:
   sdk: '>=2.12.0 <3.0.0'

src/updaters/dart/pubspec-yaml.ts

@@ -24,23 +24,30 @@ export class PubspecYaml extends DefaultUpdater {
    * @param {string} content The initial content
    * @returns {string} The updated content
    */
+
   updateContent(content: string): string {
-    const oldVersion = content.match(/version: ([0-9.]+)\+?([0-9]*$)/);
+    const oldVersion = content.match(/^version: ([0-9.]+)\+?(.*$)/m);
     let buildNumber = '';
 
     if (oldVersion) {
-      buildNumber = `${oldVersion[2]}`;
-      if (buildNumber.length > 0) {
+      buildNumber = oldVersion[2];
+      const parsedBuild = parseInt(buildNumber);
+      if (!isNaN(parsedBuild)) {
+        buildNumber = `+${parsedBuild + 1}`;
+        logger.info(
+          `updating from ${oldVersion[1]}+${oldVersion[2]} to ${this.version}${buildNumber}`
+        );
+      } else if (buildNumber.length > 0) {
         buildNumber = `+${buildNumber}`;
         logger.info(
-          `updating from ${oldVersion[1]}${buildNumber} to ${this.version}${buildNumber}`
+          `updating from ${oldVersion[1]}+${oldVersion[2]} to ${this.version}${buildNumber}`
         );
       } else {
         logger.info(`updating from ${oldVersion[1]} to ${this.version}`);
       }
     }
     return content.replace(
-      /version: ([0-9.]+)\+?([0-9]*$)/,
+      /^version: .*$/m,
       `version: ${this.version}${buildNumber}`
     );
   }

test/updaters/fixtures/pubspec_with_build_no_bad.yaml

@@ -0,0 +1,8 @@
+name: hello_world
+description: Hello World
+publish_to: 'none' # Remove this line if you wish to publish to pub.dev
+
+version: 0.5.0+abc
+
+environment:
+  sdk: '>=2.12.0 <3.0.0'

test/updaters/pubspec-yaml.ts

@@ -27,24 +27,36 @@ describe('PubspecYaml', () => {
       const oldContent = readFileSync(
         resolve(fixturesPath, './pubspec.yaml'),
         'utf8'
-      ).replace(/\r\n/g, '\n');
+      ).replace(/\r\n/g, '\n'); // required for windows
       const version = new PubspecYaml({
         version: Version.parse('0.6.0'),
       });
       const newContent = version.updateContent(oldContent);
-      snapshot(newContent.replace(/\r\n/g, '\n'));
+      snapshot(newContent);
     });
 
     it('updates version with build number in pubspec.yaml file', async () => {
       const oldContent = readFileSync(
         resolve(fixturesPath, './pubspec_with_build_no.yaml'),
         'utf8'
-      ).replace(/\r\n/g, '\n');
+      ).replace(/\r\n/g, '\n'); // required for windows
       const version = new PubspecYaml({
         version: Version.parse('0.6.0'),
       });
       const newContent = version.updateContent(oldContent);
-      snapshot(newContent.replace(/\r\n/g, '\n'));
+      snapshot(newContent);
+    });
+
+    it('leaves malformatted build numbers alone in pubspec.yaml file', async () => {
+      const oldContent = readFileSync(
+        resolve(fixturesPath, './pubspec_with_build_no_bad.yaml'),
+        'utf8'
+      ).replace(/\r\n/g, '\n'); // required for windows
+      const version = new PubspecYaml({
+        version: Version.parse('0.6.0'),
+      });
+      const newContent = version.updateContent(oldContent);
+      snapshot(newContent);
     });
   });
 });