From c4b02b0003ff1812ec064c8f6144629975b52933 Mon Sep 17 00:00:00 2001 From: Jeff Ching Date: Mon, 14 Feb 2022 14:23:05 -0800 Subject: [PATCH 1/2] test: failing test for returning uploadUrl and body when creating release --- test/github.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/test/github.ts b/test/github.ts index d2064b482..5df782566 100644 --- a/test/github.ts +++ b/test/github.ts @@ -604,6 +604,7 @@ describe('GitHub', () => { upload_url: 'https://uploads.github.com/repos/fake/fake/releases/1/assets{?name,label}', target_commitish: 'abc123', + body: 'Some release notes response.', }); const release = await github.createRelease({ tag: new TagName(Version.parse('1.2.3')), @@ -625,6 +626,10 @@ describe('GitHub', () => { expect(release.tagName).to.eql('v1.2.3'); expect(release.sha).to.eql('abc123'); expect(release.draft).to.be.false; + expect(release.uploadUrl).to.eql( + 'https://uploads.github.com/repos/fake/fake/releases/1/assets{?name,label}' + ); + expect(release.notes).to.eql('Some release notes response.'); }); it('should raise a DuplicateReleaseError if already_exists', async () => { From a38bd6788eeb13142a55bac0048ea1134fbcaf2b Mon Sep 17 00:00:00 2001 From: Jeff Ching Date: Mon, 14 Feb 2022 14:23:46 -0800 Subject: [PATCH 2/2] fix: return uploadUrl and body when creating release --- src/github.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/github.ts b/src/github.ts index b3199ebb7..e746cc0e8 100644 --- a/src/github.ts +++ b/src/github.ts @@ -163,6 +163,7 @@ export interface GitHubRelease { notes?: string; url: string; draft?: boolean; + uploadUrl?: string; } export interface GitHubTag { @@ -1246,9 +1247,14 @@ export class GitHub { name: resp.data.name || undefined, tagName: resp.data.tag_name, sha: resp.data.target_commitish, - notes: resp.data.body_text, + notes: + resp.data.body_text || + resp.data.body || + resp.data.body_html || + undefined, url: resp.data.html_url, draft: resp.data.draft, + uploadUrl: resp.data.upload_url, }; }, e => {