Skip to content

Commit 66ef85b

Browse files
Fixed misleading log when server_name is '0.0.0.0' (#2176)
* Fixed misleading log when server_name is '0.0.0.0' * some cleanups * formatting Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
1 parent 090622c commit 66ef85b

4 files changed

Lines changed: 12 additions & 5 deletions

File tree

gradio/blocks.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -983,19 +983,21 @@ def reverse(text):
983983
"Rerunning server... use `close()` to stop if you need to change `launch()` parameters.\n----"
984984
)
985985
else:
986-
server_port, path_to_local_server, app, server = networking.start_server(
986+
server_name, server_port, local_url, app, server = networking.start_server(
987987
self,
988988
server_name,
989989
server_port,
990990
ssl_keyfile,
991991
ssl_certfile,
992992
ssl_keyfile_password,
993993
)
994-
self.local_url = path_to_local_server
994+
self.server_name = server_name
995+
self.local_url = local_url
995996
self.server_port = server_port
996997
self.server_app = app
997998
self.server = server
998999
self.is_running = True
1000+
self.protocol = "https" if self.local_url.startswith("https") else "http"
9991001

10001002
event_queue.Queue.set_url(self.local_url)
10011003
# Cannot run async functions in background other than app's scope.
@@ -1023,7 +1025,11 @@ def reverse(text):
10231025
else:
10241026
print(strings.en["COLAB_DEBUG_FALSE"])
10251027
else:
1026-
print(strings.en["RUNNING_LOCALLY"].format(self.local_url))
1028+
print(
1029+
strings.en["RUNNING_LOCALLY_SEPARATED"].format(
1030+
self.protocol, self.server_name, self.server_port
1031+
)
1032+
)
10271033
if is_colab and self.requires_permissions:
10281034
print(strings.en["MEDIA_PERMISSIONS_IN_COLAB"])
10291035

gradio/networking.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ def start_server(
154154
)
155155
server = Server(config=config)
156156
server.run_in_thread()
157-
return port, path_to_local_server, app, server
157+
return server_name, port, path_to_local_server, app, server
158158

159159

160160
def setup_tunnel(local_server_port: int, endpoint: str) -> str:

gradio/strings.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
en = {
88
"RUNNING_LOCALLY": "Running on local URL: {}",
9+
"RUNNING_LOCALLY_SEPARATED": "Running on local URL: {}://{}:{}",
910
"SHARE_LINK_DISPLAY": "Running on public URL: {}",
1011
"COULD_NOT_GET_SHARE_LINK": "\nCould not create share link, please check your internet connection.",
1112
"COLAB_NO_LOCAL": "Cannot display local interface on google colab, public link created.",

test/test_networking.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ def test_start_server(self):
6868
networking.INITIAL_PORT_VALUE + networking.TRY_NUM_PORTS,
6969
)
7070
io.enable_queue = False
71-
_, local_path, _, server = networking.start_server(io, server_port=port)
71+
_, _, local_path, _, server = networking.start_server(io, server_port=port)
7272
url = urllib.parse.urlparse(local_path)
7373
self.assertEquals(url.scheme, "http")
7474
self.assertEquals(url.port, port)

0 commit comments

Comments
 (0)