bugfix for issue #125 (#126)

* bugfix

* changes

* added test

---------

Co-authored-by: Abubakar Abid <abubakar@huggingface.co>

Author: universuen

tests/e2e/__pycache__/test_basic_logging.cpython-312-pytest-8.3.4.pyc

@@ -18,3 +18,21 @@ def test_basic_logging(temp_db):
     assert results[1]["step"] == 1
     assert "timestamp" in results[0]
     assert "timestamp" in results[1]
+
+
+def test_basic_logging_with_step(temp_db):
+    trackio.init(project="test_project", name="test_run")
+    trackio.log(metrics={"loss": 0.1}, step=0)
+    trackio.log(metrics={"loss": 0.2, "acc": 0.9}, step=2)
+    trackio.finish()
+
+    results = SQLiteStorage.get_metrics(project="test_project", run="test_run")
+    assert len(results) == 2
+    assert results[0]["loss"] == 0.1
+    assert results[0]["step"] == 0
+
+    assert results[1]["loss"] == 0.2
+    assert results[1]["acc"] == 0.9
+    assert results[1]["step"] == 2
+    assert "timestamp" in results[0]
+    assert "timestamp" in results[1]

tests/e2e/test_basic_logging.py

@@ -129,8 +129,11 @@ def log(metrics: dict, step: int | None = None) -> None:
     """
     run = context_vars.current_run.get()
     if run is None:
-        raise RuntimeError("Call trackio.init() before log().")
-    run.log(metrics)
+        raise RuntimeError("Call trackio.init() before trackio.log().")
+    run.log(
+        metrics=metrics,
+        step=step,
+    )
 
 
 def finish():
@@ -139,7 +142,7 @@ def finish():
     """
     run = context_vars.current_run.get()
     if run is None:
-        raise RuntimeError("Call trackio.init() before finish().")
+        raise RuntimeError("Call trackio.init() before trackio.finish().")
     run.finish()
 
 

trackio/__init__.py

@@ -1 +1 @@
-0.2.2
+0.2.3