Merge remote-tracking branch 'origin/main' into trace-proposal

# Conflicts:
#	trackio/frontend/src/App.svelte

Author: abidlabs

.changeset/strong-taxis-fail.md

@@ -0,0 +1,5 @@
+---
+"trackio": patch
+---
+
+feat:Restore sidebar share and embed snippets, and fix query parameter regression

tests/ui/test_share_url_query_params.py

@@ -0,0 +1,99 @@
+from urllib.parse import urlencode, urlparse, urlunparse
+
+from playwright.sync_api import expect, sync_playwright
+
+import trackio
+
+
+def _url_with_query(base_url: str, params: dict[str, str]) -> str:
+    parsed = urlparse(base_url)
+    path = parsed.path if parsed.path else "/"
+    query = urlencode(params)
+    return urlunparse((parsed.scheme, parsed.netloc, path, "", query, ""))
+
+
+def test_share_view_query_params_apply(temp_dir):
+    project = "test_share_qp"
+    run_ids_by_name: dict[str, list[str]] = {}
+    for name in ("run-alpha", "run-beta", "run-alpha"):
+        run = trackio.init(project=project, name=name)
+        run_ids_by_name.setdefault(name, []).append(run.id)
+        for _ in range(3):
+            trackio.log(metrics={"loss": 0.1, "accuracy": 0.9})
+        trackio.finish()
+
+    alpha_ids = run_ids_by_name["run-alpha"]
+    assert len(alpha_ids) == 2
+
+    app, _, _, full_url = trackio.show(
+        project=project, block_thread=False, open_browser=False
+    )
+
+    try:
+        with sync_playwright() as p:
+            browser = p.chromium.launch()
+            page = browser.new_page()
+            page.set_default_timeout(15000)
+
+            primary = _url_with_query(
+                full_url,
+                {
+                    "project": project,
+                    "run_ids": alpha_ids[0],
+                    "metric_filter": "^loss$",
+                    "sidebar": "hidden",
+                    "navbar": "hidden",
+                    "accordion": "hidden",
+                },
+            )
+            page.goto(primary)
+            page.wait_for_load_state("networkidle")
+
+            expect(page.locator(".navbar")).to_have_count(0)
+            expect(page.locator(".sidebar")).to_have_count(0)
+            expect(page.locator(".accordion")).to_have_count(0)
+
+            expect(page.locator(".metrics-page")).to_be_visible()
+            expect(page.locator(".vega-embed")).to_have_count(1)
+            expect(page.locator(".metrics-page .legend-dot")).to_have_count(1)
+
+            duplicate = _url_with_query(
+                full_url,
+                {
+                    "project": project,
+                    "run_ids": ",".join(alpha_ids),
+                    "metric_filter": "^loss$",
+                    "sidebar": "hidden",
+                    "navbar": "hidden",
+                    "accordion": "hidden",
+                },
+            )
+            page.goto(duplicate)
+            page.wait_for_load_state("networkidle")
+
+            expect(page.locator(".metrics-page")).to_be_visible()
+            expect(page.locator(".vega-embed")).to_have_count(1)
+            expect(page.locator(".metrics-page .legend-dot")).to_have_count(2)
+
+            legacy = _url_with_query(
+                full_url,
+                {
+                    "project": project,
+                    "runs": "run-beta",
+                    "metrics": "loss",
+                    "sidebar": "hidden",
+                    "navbar": "hidden",
+                    "accordion": "hidden",
+                },
+            )
+            page.goto(legacy)
+            page.wait_for_load_state("networkidle")
+
+            expect(page.locator(".navbar")).to_have_count(0)
+            expect(page.locator(".vega-embed")).to_have_count(1)
+            expect(page.locator(".metrics-page .legend-dot")).to_have_count(1)
+
+            browser.close()
+    finally:
+        trackio.delete_project(project, force=True)
+        app.close()

trackio/frontend/src/App.svelte

@@ -32,6 +32,23 @@
   import Settings from "./pages/Settings.svelte";
   import { initTheme, isDark, onThemeChange } from "./lib/theme.js";
 
+  function metricFilterFromLegacyMetricsParam(metricsParam) {
+    if (!metricsParam) return "";
+    const trimmed = metricsParam.trim();
+    const parts = trimmed.split(",").map((s) => s.trim()).filter(Boolean);
+    if (parts.length === 0) return "";
+    const isSimpleToken = (p) => /^[\w./-]+$/.test(p);
+    if (parts.every(isSimpleToken)) {
+      return parts
+        .map((p) => {
+          const esc = p.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
+          return `^${esc}$`;
+        })
+        .join("|");
+    }
+    return trimmed;
+  }
+
   initTheme();
 
   let darkMode = $state(isDark());
@@ -53,6 +70,7 @@
   let metricColumns = $state([]);
   let sidebarOpen = $state(true);
   let sidebarHidden = $state(false);
+  let navbarHidden = $state(false);
   let urlTick = $state(0);
   let alerts = $state([]);
   let pollTimer = $state(null);
@@ -212,6 +230,11 @@
     refreshRuns();
   });
 
+  $effect(() => {
+    urlTick;
+    navbarHidden = getQueryParam("navbar") === "hidden";
+  });
+
   onMount(() => {
     const sidebarParam = getQueryParam("sidebar");
     if (sidebarParam === "hidden") {
@@ -230,17 +253,12 @@
       if (!Number.isNaN(s)) smoothing = s;
     }
 
-    const metricsParam = getQueryParam("metrics");
-    if (metricsParam) {
-      const parts = metricsParam.split(",").map((s) => s.trim()).filter(Boolean);
-      if (parts.length) {
-        metricFilter = parts
-          .map((p) => {
-            const esc = p.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
-            return `^${esc}$`;
-          })
-          .join("|");
-      }
+    const metricFilterParam = getQueryParam("metric_filter");
+    const metricsLegacyParam = getQueryParam("metrics");
+    if (metricFilterParam) {
+      metricFilter = metricFilterParam;
+    } else if (metricsLegacyParam) {
+      metricFilter = metricFilterFromLegacyMetricsParam(metricsLegacyParam);
     }
 
     if (getQueryParam("accordion") === "hidden") {
@@ -286,6 +304,7 @@
         }
         await refreshProjects();
         await refreshRuns();
+
         await refreshAlerts();
       } catch (e) {
         console.error("Failed to load projects:", e);
@@ -317,6 +336,38 @@
     if (projectLocked) applyLockedProject();
   });
 
+  let urlRunsFromQueryApplied = $state(false);
+
+  $effect(() => {
+    if (urlRunsFromQueryApplied) return;
+    if (!appBootstrapReady) return;
+    if (!selectedProject) return;
+    const runIdsParam = getQueryParam("run_ids");
+    const runsParam = getQueryParam("runs");
+    if (!runIdsParam && !runsParam) {
+      urlRunsFromQueryApplied = true;
+      return;
+    }
+    if (!runs.length) {
+      urlRunsFromQueryApplied = true;
+      return;
+    }
+    let wanted;
+    if (runIdsParam) {
+      const ids = runIdsParam.split(",").map((s) => s.trim()).filter(Boolean);
+      const validKeys = new Set(runs.map((r) => runKey(r)));
+      wanted = ids.filter((id) => validKeys.has(id));
+    } else {
+      const names = runsParam.split(",").map((s) => s.trim()).filter(Boolean);
+      const wantedNames = new Set(names);
+      wanted = runs.filter((r) => wantedNames.has(r.name)).map((r) => runKey(r));
+    }
+    if (wanted.length) {
+      selectedRuns = wanted;
+    }
+    urlRunsFromQueryApplied = true;
+  });
+
   let showSidebar = $derived(
     currentPage === "metrics" ||
       currentPage === "traces" ||
@@ -361,13 +412,16 @@
       bind:selectedSystemDevices
       bind:traceModel
       {traceModelChoices}
+      {spaceId}
       {logoUrls}
       {darkMode}
     />
   {/if}
 
   <div class="main">
-    <Navbar {currentPage} onNavigate={handleNavigate} />
+    {#if !navbarHidden}
+      <Navbar {currentPage} onNavigate={handleNavigate} />
+    {/if}
 
     <div class="page-content">
       {#if currentPage === "metrics"}