Restores tooltips to line plots and fixes the call to uses TTL instead of OAuth (#470)

Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

Author: abidlabs

.changeset/mighty-owls-feel.md

@@ -0,0 +1,5 @@
+---
+"trackio": minor
+---
+
+feat:Restores tooltips to line plots and fixes the call to uses TTL instead of OAuth

trackio/frontend/src/App.svelte

@@ -181,7 +181,7 @@
     if (mutationPollTimer) clearInterval(mutationPollTimer);
     mutationPollTimer = setInterval(() => {
       refreshMutationAccess();
-    }, 15000);
+    }, 120000);
   }
 
   $effect(() => {

trackio/frontend/src/components/LinePlot.svelte

@@ -115,6 +115,35 @@
       ...extra,
     });
 
+    const yTitle = y.includes("/") ? y.split("/").pop() : y;
+    const tooltipEnc = [
+      { field: colorField, type: "nominal", title: "Run" },
+      { field: x, type: "quantitative", title: x },
+      { field: y, type: "quantitative", title: yTitle },
+    ];
+
+    const hoverParams = [{
+      name: "hover",
+      select: { type: "point", on: "pointerover", nearest: true, clear: "pointerout" },
+    }];
+
+    const hoverPointLayer = (dataSpec, layerName) => ({
+      ...dataSpec,
+      mark: { type: "circle", clip: true, size: 60, opacity: 0 },
+      encoding: {
+        x: xEnc,
+        y: yEnc,
+        ...colorEnc,
+        tooltip: tooltipEnc,
+        opacity: {
+          condition: { param: "hover", empty: false, value: 1 },
+          value: 0,
+        },
+      },
+      params: hoverParams,
+      name: layerName,
+    });
+
     if (hasSmoothed) {
       layers.push({
         data: { name: "data_original", values: originalData },
@@ -128,17 +157,21 @@
         encoding: { x: xEnc, y: yEnc, ...colorEnc },
         name: "plot",
       });
+      layers.push(
+        hoverPointLayer({ data: { name: "data_smoothed", values: smoothedData } }, "hover_points"),
+      );
     } else {
       layers.push({
         data: { name: "data_plot", values: data },
         mark: lineMark(),
         encoding: { x: xEnc, y: yEnc, ...colorEnc },
         name: "plot",
       });
+      layers.push(
+        hoverPointLayer({ data: { name: "data_plot", values: data } }, "hover_points"),
+      );
     }
 
-    const yTitle = y.includes("/") ? y.split("/").pop() : y;
-
     return {
       $schema: "https://vega.github.io/schema/vega-lite/v5.json",
       title: {

trackio/server.py

@@ -279,22 +279,38 @@ def check_hf_token_has_write_access(hf_token: str | None) -> None:
             )
 
 
-@lru_cache(maxsize=32)
+_oauth_write_cache: dict[str, tuple[bool, float]] = {}
+_OAUTH_WRITE_CACHE_TTL = 300
+
+
 def check_oauth_token_has_write_access(oauth_token: str | None) -> None:
     if not os.getenv("SYSTEM") == "spaces":
         return
     if oauth_token is None:
         raise PermissionError(
             "Expected an oauth to be provided when logging to a Space"
         )
+    now = time.monotonic()
+    cached = _oauth_write_cache.get(oauth_token)
+    if cached is not None:
+        allowed, ts = cached
+        if now - ts < _OAUTH_WRITE_CACHE_TTL:
+            if not allowed:
+                raise PermissionError(
+                    "Expected the oauth token to be the user owner of the space, or be a member of the org owner of the space"
+                )
+            return
     who = HfApi.whoami(oauth_token)
     user_name = who["name"]
     owner_name = os.getenv("SPACE_AUTHOR_NAME")
     if user_name == owner_name:
+        _oauth_write_cache[oauth_token] = (True, now)
         return
     for org in who["orgs"]:
         if org["name"] == owner_name and org["roleInOrg"] == "write":
+            _oauth_write_cache[oauth_token] = (True, now)
             return
+    _oauth_write_cache[oauth_token] = (False, now)
     raise PermissionError(
         "Expected the oauth token to be the user owner of the space, or be a member of the org owner of the space"
     )