Skip to content

Commit 2c626ed

Browse files
authored
chore: Update approvals policy (#1592)
1 parent 7180c72 commit 2c626ed

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/CODEOWNERS

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,9 @@
5959
/js-runner/LICENSE @ospencer @peblair
6060

6161
/stdlib/ @ospencer @phated @peblair @marcusroberts @jozanza
62-
/stdlib/runtime/ @ospencer @peblair @jozanza
62+
/stdlib/runtime/ @ospencer @peblair @jozanza @phated
6363
/stdlib/package.json @phated @ospencer
64-
/stdlib/index.js @phated
64+
/stdlib/index.js @phated @ospencer
6565
/stdlib/LICENSE @ospencer @peblair
6666

6767
/.gitattributes @phated @ospencer

docs/contributor/commits_pull_requests_and_merging.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ The easiest way to do this is to have multiple Conventional Commits while you wo
8181

8282
### Reviews
8383

84-
As the Grain core team has grown, we've adjusted our code review process. On the [grain-lang/grain](https://github.com/grain-lang/grain) repository, we require **one** approval from a "code owner", as defined in the [CODEOWNERS](/.github/CODEOWNERS) file for any non-breaking pull request and approvals from **all** "code owners" for pull requests containing breaking changes. For any other repositories in the grain-lang organization, we require **one** approval from any core team member.
84+
As the Grain core team has grown, we've adjusted our code review process. On the [grain-lang/grain](https://github.com/grain-lang/grain) repository, we require code approvals as defined by the [CODEOWNERS](/.github/CODEOWNERS) file. **One** codeowner of each file changed in the pull request must approve of the changes before the changes are merged, as enforced by GitHub. Non-breaking pull requests may be merged at any time. Breaking pull requests should only be merged when the core team has general agreement of the changes and is preparing a breaking release. For any other repositories in the grain-lang organization, we require **one** approval from any core team member.
8585

8686
### With Breaking Changes
8787

0 commit comments

Comments
 (0)