chore(compiler)!: Remove built-in FileDescriptor type (#1747)

Author: ospencer

compiler/src/typed/builtin_types.re

@@ -63,7 +63,6 @@ and ident_char = ident_create("Char")
 and ident_void = ident_create("Void")
 and ident_box = ident_create("Box")
 and ident_array = ident_create("Array")
-and ident_fd = ident_create("FileDescriptor")
 and ident_assertion_error = ident_create_predef_exn("AssertionError")
 and ident_index_out_of_bounds = ident_create_predef_exn("IndexOutOfBounds")
 and ident_index_non_integer = ident_create_predef_exn("IndexNonInteger")
@@ -97,8 +96,7 @@ and path_bytes = PIdent(ident_bytes)
 and path_char = PIdent(ident_char)
 and path_void = PIdent(ident_void)
 and path_box = PIdent(ident_box)
-and path_array = PIdent(ident_array)
-and path_fd = PIdent(ident_fd);
+and path_array = PIdent(ident_array);
 
 let type_number = newgenty(TTyConstr(path_number, [], ref(TMemNil)))
 and type_exception = newgenty(TTyConstr(path_exception, [], ref(TMemNil)))
@@ -138,7 +136,6 @@ and type_void = newgenty(TTyConstr(path_void, [], ref(TMemNil)))
 and type_box = var => newgenty(TTyConstr(path_box, [var], ref(TMemNil)))
 and type_array = var =>
   newgenty(TTyConstr(path_array, [var], ref(TMemNil)))
-and type_fd = newgenty(TTyConstr(path_fd, [], ref(TMemNil)))
 and type_lambda = (args, res) => newgenty(TTyArrow(args, res, TComOk));
 
 let decl_abstr = path => {
@@ -306,7 +303,6 @@ let initial_env = (add_type, add_extension, empty_env) =>
   |> add_type(ident_char, decl_abstr_imm(WasmI32, path_char))
   |> add_type(ident_void, decl_void)
   |> add_type(ident_array, decl_array)
-  |> add_type(ident_fd, decl_abstr(path_fd))
   |> add_type(ident_bytes, decl_abstr(path_bytes))
   |> add_extension(ident_assertion_error, decl_assertion_error)
   |> add_extension(ident_index_out_of_bounds, decl_index_out_of_bounds)

compiler/test/__snapshots__/arrays.0f9e7d37.0.snapshot

@@ -130,7 +130,7 @@ arrays › array_access
            )
            (i32.store offset=12
             (local.get $0)
-            (i32.const 69)
+            (i32.const 67)
            )
            (i32.store offset=16
             (local.get $0)
@@ -164,7 +164,7 @@ arrays › array_access
            )
            (i32.store offset=12
             (local.get $0)
-            (i32.const 71)
+            (i32.const 69)
            )
            (i32.store offset=16
             (local.get $0)
@@ -230,7 +230,7 @@ arrays › array_access
          )
          (i32.store offset=12
           (local.get $0)
-          (i32.const 69)
+          (i32.const 67)
          )
          (i32.store offset=16
           (local.get $0)

compiler/test/__snapshots__/arrays.1deb7b51.0.snapshot

@@ -134,7 +134,7 @@ arrays › array_access5
              )
              (i32.store offset=12
               (local.get $0)
-              (i32.const 69)
+              (i32.const 67)
              )
              (i32.store offset=16
               (local.get $0)
@@ -168,7 +168,7 @@ arrays › array_access5
              )
              (i32.store offset=12
               (local.get $0)
-              (i32.const 71)
+              (i32.const 69)
              )
              (i32.store offset=16
               (local.get $0)
@@ -234,7 +234,7 @@ arrays › array_access5
            )
            (i32.store offset=12
             (local.get $0)
-            (i32.const 69)
+            (i32.const 67)
            )
            (i32.store offset=16
             (local.get $0)

compiler/test/__snapshots__/arrays.28fcc534.0.snapshot

@@ -130,7 +130,7 @@ arrays › array_access4
            )
            (i32.store offset=12
             (local.get $0)
-            (i32.const 69)
+            (i32.const 67)
            )
            (i32.store offset=16
             (local.get $0)
@@ -164,7 +164,7 @@ arrays › array_access4
            )
            (i32.store offset=12
             (local.get $0)
-            (i32.const 71)
+            (i32.const 69)
            )
            (i32.store offset=16
             (local.get $0)
@@ -230,7 +230,7 @@ arrays › array_access4
          )
          (i32.store offset=12
           (local.get $0)
-          (i32.const 69)
+          (i32.const 67)
          )
          (i32.store offset=16
           (local.get $0)

compiler/test/__snapshots__/arrays.4c8c9f91.0.snapshot

@@ -130,7 +130,7 @@ arrays › array_access2
            )
            (i32.store offset=12
             (local.get $0)
-            (i32.const 69)
+            (i32.const 67)
            )
            (i32.store offset=16
             (local.get $0)
@@ -164,7 +164,7 @@ arrays › array_access2
            )
            (i32.store offset=12
             (local.get $0)
-            (i32.const 71)
+            (i32.const 69)
            )
            (i32.store offset=16
             (local.get $0)
@@ -230,7 +230,7 @@ arrays › array_access2
          )
          (i32.store offset=12
           (local.get $0)
-          (i32.const 69)
+          (i32.const 67)
          )
          (i32.store offset=16
           (local.get $0)

compiler/test/__snapshots__/arrays.6eac4e1f.0.snapshot

@@ -130,7 +130,7 @@ arrays › array_access3
            )
            (i32.store offset=12
             (local.get $0)
-            (i32.const 69)
+            (i32.const 67)
            )
            (i32.store offset=16
             (local.get $0)
@@ -164,7 +164,7 @@ arrays › array_access3
            )
            (i32.store offset=12
             (local.get $0)
-            (i32.const 71)
+            (i32.const 69)
            )
            (i32.store offset=16
             (local.get $0)
@@ -230,7 +230,7 @@ arrays › array_access3
          )
          (i32.store offset=12
           (local.get $0)
-          (i32.const 69)
+          (i32.const 67)
          )
          (i32.store offset=16
           (local.get $0)

compiler/test/__snapshots__/arrays.74d79181.0.snapshot

@@ -130,7 +130,7 @@ arrays › array_access5
            )
            (i32.store offset=12
             (local.get $0)
-            (i32.const 69)
+            (i32.const 67)
            )
            (i32.store offset=16
             (local.get $0)
@@ -164,7 +164,7 @@ arrays › array_access5
            )
            (i32.store offset=12
             (local.get $0)
-            (i32.const 71)
+            (i32.const 69)
            )
            (i32.store offset=16
             (local.get $0)
@@ -230,7 +230,7 @@ arrays › array_access5
          )
          (i32.store offset=12
           (local.get $0)
-          (i32.const 69)
+          (i32.const 67)
          )
          (i32.store offset=16
           (local.get $0)

compiler/test/__snapshots__/basic_functionality.2bcc447b.0.snapshot

@@ -158,7 +158,7 @@ basic functionality › assert2
         )
         (i32.store offset=12
          (local.get $0)
-         (i32.const 67)
+         (i32.const 65)
         )
         (i32.store offset=16
          (local.get $0)