feat(compiler): Remove Pervasives' dependency on toString when types are elided (#1664)

* feat(compiler): Remove Pervasives' dependency on toString when types are elided

* feat(compiler): Optimize away simple unary boolean operations

* snapshots

Author: ospencer

compiler/src/middle_end/optimize.re

@@ -14,7 +14,7 @@ let optimization_passes = [
   Optimize_manual_memory_management.optimize,
   Optimize_tail_calls.optimize,
   Optimize_constants.optimize,
-  Optimize_simple_binops.optimize,
+  Optimize_simple_expressions.optimize,
   Optimize_dead_assignments.optimize,
   Optimize_dead_branches.optimize,
   Optimize_dead_statements.optimize,

…src/middle_end/optimize_simple_binops.re …iddle_end/optimize_simple_expressions.recompiler/src/middle_end/optimize_simple_binops.re renamed to compiler/src/middle_end/optimize_simple_expressions.re compiler/src/middle_end/optimize_simple_binops.re renamed to compiler/src/middle_end/optimize_simple_expressions.re

@@ -65,6 +65,10 @@ module ConstantFoldingArg: Anf_mapper.MapArgument = {
       | "==" => wrap_imm @@ Const_bool(x == y)
       | _ => c
       };
+    | CPrim1(Not, {imm_desc: ImmConst(Const_bool(b))} as i) => {
+        ...c,
+        comp_desc: CImmExpr({...i, imm_desc: ImmConst(Const_bool(!b))}),
+      }
     | CPrim2(prim2, {imm_desc: ImmConst(x)} as i, {imm_desc: ImmConst(y)}) =>
       let wrap_imm = imm => {
         ...c,

…rc/middle_end/optimize_simple_binops.rei …ddle_end/optimize_simple_expressions.reicompiler/src/middle_end/optimize_simple_binops.rei renamed to compiler/src/middle_end/optimize_simple_expressions.rei compiler/src/middle_end/optimize_simple_binops.rei renamed to compiler/src/middle_end/optimize_simple_expressions.rei

@@ -6,7 +6,8 @@ open Parsetree;
 type primitive_constant =
   | HeapBase
   | HeapStart
-  | HeapTypeMetadata;
+  | HeapTypeMetadata
+  | ElideTypeInfo;
 
 type primitive =
   | PrimitiveConstant(primitive_constant)
@@ -49,6 +50,7 @@ let prim_map =
       ("@heap.base", PrimitiveConstant(HeapBase)),
       ("@heap.start", PrimitiveConstant(HeapStart)),
       ("@heap.type_metadata", PrimitiveConstant(HeapTypeMetadata)),
+      ("@meta.elide_type_info", PrimitiveConstant(ElideTypeInfo)),
       ("@allocate.int32", Primitive0(AllocateInt32)),
       ("@allocate.int64", Primitive0(AllocateInt64)),
       ("@allocate.uint32", Primitive0(AllocateUint32)),
@@ -1502,6 +1504,10 @@ let transl_prim = (env, desc) => {
             Constant.wasmi32(string_of_int(active_memory_base() + 0x8)),
             true,
           )
+        | ElideTypeInfo => (
+            Constant.bool(Grain_utils.Config.elide_type_info^),
+            false,
+          )
         };
       let attrs =
         if (needs_disablegc) {

compiler/src/typed/translprim.re

@@ -3,7 +3,8 @@ open Typedtree;
 type primitive_constant =
   | HeapBase
   | HeapStart
-  | HeapTypeMetadata;
+  | HeapTypeMetadata
+  | ElideTypeInfo;
 
 type primitive =
   | PrimitiveConstant(primitive_constant)

compiler/src/typed/translprim.rei

@@ -33,10 +33,7 @@ basic functionality › not1
    (block $cleanup_locals.2 (result i32)
     (local.set $0
      (block $compile_block.1 (result i32)
-      (i32.xor
-       (i32.const -2)
-       (i32.const -2147483648)
-      )
+      (i32.const 2147483646)
      )
     )
     (local.get $0)

compiler/test/__snapshots__/basic_functionality.4d6f9417.0.snapshot

@@ -33,10 +33,7 @@ basic functionality › not2
    (block $cleanup_locals.2 (result i32)
     (local.set $0
      (block $compile_block.1 (result i32)
-      (i32.xor
-       (i32.const 2147483646)
-       (i32.const -2147483648)
-      )
+      (i32.const -2)
      )
     )
     (local.get $0)

compiler/test/__snapshots__/basic_functionality.970a2a2b.0.snapshot

@@ -523,6 +523,7 @@ provide primitive box: a -> Box<a> = "@box"
 provide primitive unbox: Box<a> -> a = "@unbox"
 
 // Setup exception printing
+primitive elideTypeInfo: Bool = "@meta.elide_type_info"
 @unsafe
 let rec setupExceptions = () => {
   Exception.dangerouslyRegisterPrinter(e => {
@@ -533,7 +534,11 @@ let rec setupExceptions = () => {
     }
   })
 
-  Exception.dangerouslyRegisterBasePrinter(e => Some(toString(e)))
+  // If type information is elided, remove dependency on toString as
+  // it will have no effect on exceptions
+  if (!elideTypeInfo) {
+    Exception.dangerouslyRegisterBasePrinter(e => Some(toString(e)))
+  }
 }
 
 setupExceptions()