Fix thread pool scope#471
Merged
Merged
Conversation
The thread pool and mutex need to be global across instances of Scope for it to be a global thread pool.
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 22, 2024
## [1.6.2](v1.6.1...v1.6.2) (2024-03-22) ### Bug Fixes * thread pool scope and mutex need to be global across all instances of Scope for it to be a global thread pool ([#471](#471)) ([51fb51c](51fb51c))
|
🎉 This PR is included in version 1.6.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Collaborator
|
references this issue: #469 |
jkeen
added a commit
to jkeen/graphiti
that referenced
this pull request
Mar 26, 2024
…er handle on what's causing the thread-pools to hang
jkeen
added a commit
to jkeen/graphiti
that referenced
this pull request
Mar 26, 2024
…er handle on what's causing the thread-pools to hang
jkeen
added a commit
to jkeen/graphiti
that referenced
this pull request
Mar 26, 2024
…er handle on what's causing the thread-pools to hang
jkeen
added a commit
that referenced
this pull request
Mar 26, 2024
…n what's causing thread pool hangs revert: "thread pool scope and mutex need to be global across all instances of Scope for it to be a global thread pool (#471)" revert: "add thread pool and concurrency_max_threads configuration option (#470)" This reverts commit 51fb51c. This reverts commit 697d761.
jkeen
added a commit
that referenced
this pull request
Mar 26, 2024
…n what's causing thread pool hangs. refs #469 revert: "thread pool scope and mutex need to be global across all instances of Scope for it to be a global thread pool (#471)" revert: "add thread pool and concurrency_max_threads configuration option (#470)" This reverts commit 51fb51c. This reverts commit 697d761.
jkeen
pushed a commit
to jkeen/graphiti
that referenced
this pull request
Mar 27, 2024
…es of Scope for it to be a global thread pool (graphiti-api#471)
jkeen
pushed a commit
to jkeen/graphiti
that referenced
this pull request
Mar 27, 2024
## [1.6.2](graphiti-api/graphiti@v1.6.1...v1.6.2) (2024-03-22) ### Bug Fixes * thread pool scope and mutex need to be global across all instances of Scope for it to be a global thread pool ([graphiti-api#471](graphiti-api#471)) ([51fb51c](graphiti-api@51fb51c))
jkeen
added a commit
to jkeen/graphiti
that referenced
this pull request
Mar 27, 2024
…n what's causing thread pool hangs. refs graphiti-api#469 revert: "thread pool scope and mutex need to be global across all instances of Scope for it to be a global thread pool (graphiti-api#471)" revert: "add thread pool and concurrency_max_threads configuration option (graphiti-api#470)" This reverts commit 51fb51c. This reverts commit 697d761.
jkeen
pushed a commit
to jkeen/graphiti
that referenced
this pull request
Mar 27, 2024
## [1.6.3](graphiti-api/graphiti@v1.6.2...v1.6.3) (2024-03-26) ### Bug Fixes * Remove thread pool executor logic until we get a better handle on what's causing thread pool hangs. refs [graphiti-api#469](graphiti-api#469) ([7941b6f](graphiti-api@7941b6f)), closes [graphiti-api#471](graphiti-api#471) [graphiti-api#470](graphiti-api#470)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The thread pool and mutex need to be global across instances of Scope for it to be a global thread pool.
See: #470