Skip to content

Svg props#172

Merged
gregberge merged 4 commits into
masterfrom
svg-props
Sep 16, 2018
Merged

Svg props#172
gregberge merged 4 commits into
masterfrom
svg-props

Conversation

@gregberge

Copy link
Copy Markdown
Owner

No description provided.

TrySound and others added 4 commits September 15, 2018 18:42
In this diff I introduce the new option `svgProps` which is similar to
svgAttributes but applies values in interpolation style `{true}`.

This allows to specify expressions depending on template values for
example default `currentColor` in `fill` prop.

I mentioned in comment about later fixing api to smooth-code/h2x#13
@gregberge gregberge self-assigned this Sep 16, 2018
@TrySound

Copy link
Copy Markdown
Contributor

Do you know you could push commits to my branch directly?

@gregberge

Copy link
Copy Markdown
Owner Author

@TrySound I didn't know! sorry

@gregberge

Copy link
Copy Markdown
Owner Author

@TrySound OK for you? I will merge it.

@TrySound

Copy link
Copy Markdown
Contributor

Sure, looks good to me. Waiting for release :)

@gregberge gregberge merged commit 9657110 into master Sep 16, 2018
@gregberge gregberge deleted the svg-props branch September 16, 2018 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants