Fix config loading#176
Merged
Merged
Conversation
Ref #174 In this diff I fixed loading config from custom path specified in `--config`. Current behaviour is loading only `svg.config.js` in directory of specified in `--config` file. This is not intuitive. Also fixed the problem of overriding options specified in config by defaults from cli.
Contributor
Author
|
/cc @neoziro |
Owner
|
Thanks! |
Contributor
Author
|
Could you make a patch release? |
Contributor
Author
|
@neoziro Now works perfectly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #174
In this diff I fixed loading config from custom path specified in
--config.Current behaviour is loading only
svg.config.jsin directory ofspecified in
--configfile. This is not intuitive.Also fixed the problem of overriding options specified in config by
defaults from cli.