fix(svg-title): dont render empty title#341
Merged
Merged
Conversation
Currently when no title is passed and titleProp is set to `true`, we are rendering an empty title element which is causing some issues. So we have added a conditional statement for rendering the title element only if the title props is not falsy. If we have an existing title, that will rendered by default. Passing the `null` values as the title will cause also cause the title element for not render even if a default title exists on the svg fixes #333
|
This pull request is automatically deployed with Now. |
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
==========================================
+ Coverage 85.03% 85.06% +0.03%
==========================================
Files 30 30
Lines 481 482 +1
Branches 134 134
==========================================
+ Hits 409 410 +1
Misses 60 60
Partials 12 12
Continue to review full report at Codecov.
|
inssein
approved these changes
Sep 19, 2019
Owner
|
Hello @sudkumar, looks good for me! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Summary
Currently when no title is passed and titleProp is set to
true, we arerendering an empty title element which is causing some issues. So we
have added a conditional statement for rendering the title element only
if the title props is not falsy. If we have an existing title, that will
rendered by default. Passing the
nullvalues as the title will causealso cause the title element for not render even if a default title
exists on the svg.
This PR also add support for preserving title attribute which may be present in the svg file.
will produce
Test plan
Tests have been updated.