Add snake_case filename option#857
Merged
Merged
Conversation
added 2 commits
April 17, 2023 07:53
* Adds `snake` case option for cli and core. * Adds `snake` case option to website docs. * Adds `snake` case option to cli tests. * Adds `snake` case option to cli readme.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## main #857 +/- ##
==========================================
+ Coverage 92.80% 92.82% +0.01%
==========================================
Files 32 32
Lines 751 753 +2
Branches 249 250 +1
==========================================
+ Hits 697 699 +2
Misses 53 53
Partials 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We are using this to convert svgs into an icon library and our company has a snake_case filename policy. Since snake_case wasn't one of the existing options, we felt a need to add it.
snakecase option for cli and core.snakecase option to website docs.snakecase option to cli tests.snakecase option to cli readme.Test plan
pnpm run testpnpm run test -t "should transform filename" packages/cli/src/util.test.ts