Skip to content

Commit bdad07e

Browse files
committed
build: add Node 10 and macOS, update JSHint and GitHub Actions, adopt QUnit
* Fix readme to correctly reflect what we actually test. We haven't tested on macOS in a long time, but we can restore that. We haven't tested on Node.js 0.8 in a long time. While our dev tooling doesn't run there, the oldest we can comfortably do is Node.js 10 so let's test on that and update our claim accordingly. * Update JSHint and use directly from npm script, instead of via Grunt. * Update GitHub Actions to v4 images to fix deprecation warnings. * Switch from unmaintained nodeunit to latest QUnit, and simplify test logic to be less indirect to increase confidence. * Remove lock file per https://timotijhof.net/posts/2024/lockfiles-for-apps-not-packages-still/
1 parent 502e7a2 commit bdad07e

10 files changed

Lines changed: 104 additions & 5934 deletions

File tree

.github/workflows/test.yml

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,30 +6,32 @@ env:
66
FORCE_COLOR: 2
77

88
jobs:
9-
run:
10-
name: Node ${{ matrix.node }} on ${{ matrix.os }}
11-
runs-on: ${{ matrix.os }}
12-
9+
tests:
1310
strategy:
1411
fail-fast: false
1512
matrix:
16-
node: [20]
17-
os: [ubuntu-latest, windows-latest]
13+
node: [10, 12, 20, 22]
14+
# Node 10-20 are not available on ARM, use macos-15-intel instead
15+
os: [ubuntu-latest, macos-15-intel, windows-latest]
16+
include:
17+
- os: macos-latest
18+
node: 22
19+
20+
name: Node ${{ matrix.node }} on ${{ matrix.os }}
21+
runs-on: ${{ matrix.os }}
1822

1923
steps:
2024
- name: Clone repository
21-
uses: actions/checkout@v3
25+
uses: actions/checkout@v4
2226

2327
- name: Set up Node.js
24-
uses: actions/setup-node@v3
28+
uses: actions/setup-node@v4
2529
with:
2630
node-version: ${{ matrix.node }}
2731

28-
- name: Install npm dependencies
29-
run: npm i
32+
- run: npm install
3033

31-
- name: Run tests
32-
run: npm test
34+
- run: npm test
3335

3436
# We test multiple Windows shells because of prior stdout buffering issues
3537
# filed against Grunt. https://github.com/joyent/node/issues/3584

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
node_modules
2+
package-lock.json

.jshintignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
node_modules

.jshintrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"curly": true,
3+
"esversion": 6,
34
"eqeqeq": true,
45
"immed": true,
56
"latedef": "nofunc",

Gruntfile.js

Lines changed: 0 additions & 48 deletions
This file was deleted.

README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
[![Tested with QUnit](https://qunitjs.com/testedwith.svg)](https://qunitjs.com/)
2+
13
# exit-x
24

35
Fork of unmaintained https://github.com/cowboy/node-exit
@@ -8,7 +10,7 @@ To make a long story short, if `process.exit` is called on Windows, script outpu
810

911
See [Node.js issue #3584](https://github.com/joyent/node/issues/3584) for further reference.
1012

11-
Tested in OS X 10.8, Windows 7 on Node.js 0.8.25 and 0.10.18.
13+
Tested with Node.js 10+ on Linux, macOS, and Windows.
1214

1315
Based on some code by [@vladikoff](https://github.com/vladikoff).
1416

0 commit comments

Comments
 (0)