feat: Use better parsing for --auth-provider-cmd (#4881)

* feat: Use better parsing for `--auth-provider-cmd`

* Apply suggestion from @yhakbar

Author: yhakbar

cli/commands/run/creds/providers/externalcmd/provider.go

@@ -14,6 +14,7 @@ import (
 	"github.com/gruntwork-io/terragrunt/options"
 	"github.com/gruntwork-io/terragrunt/pkg/log"
 	"github.com/gruntwork-io/terragrunt/shell"
+	"github.com/mattn/go-shellwords"
 )
 
 // Provider runs external command that returns a json string with credentials.
@@ -35,15 +36,21 @@ func (provider *Provider) Name() string {
 
 // GetCredentials implements providers.GetCredentials
 func (provider *Provider) GetCredentials(ctx context.Context, l log.Logger) (*providers.Credentials, error) {
-	command := provider.terragruntOptions.AuthProviderCmd
-	if command == "" {
+	if provider.terragruntOptions.AuthProviderCmd == "" {
 		return nil, nil
 	}
 
-	var args []string
+	parser := shellwords.NewParser()
 
-	if parts := strings.Fields(command); len(parts) > 1 {
-		command = parts[0]
+	parts, err := parser.Parse(provider.terragruntOptions.AuthProviderCmd)
+	if err != nil {
+		return nil, errors.Errorf("failed to parse auth provider command: %w", err)
+	}
+
+	command := parts[0]
+
+	args := []string{}
+	if len(parts) > 1 {
 		args = parts[1:]
 	}
 
@@ -53,7 +60,10 @@ func (provider *Provider) GetCredentials(ctx context.Context, l log.Logger) (*pr
 	}
 
 	if output.Stdout.String() == "" {
-		return nil, errors.Errorf("command %s completed successfully, but the response does not contain JSON string", command)
+		return nil, errors.Errorf(
+			"command %s completed successfully, but the response does not contain JSON string",
+			provider.terragruntOptions.AuthProviderCmd,
+		)
 	}
 
 	resp := &Response{Envs: make(map[string]string)}

go.mod

@@ -241,6 +241,7 @@ require (
 	github.com/mattn/go-colorable v0.1.14 // indirect
 	github.com/mattn/go-localereader v0.0.1 // indirect
 	github.com/mattn/go-runewidth v0.0.16 // indirect
+	github.com/mattn/go-shellwords v1.0.12 // indirect
 	github.com/microcosm-cc/bluemonday v1.0.27 // indirect
 	github.com/mitchellh/copystructure v1.2.0 // indirect
 	github.com/mitchellh/go-testing-interface v1.14.1 // indirect

go.sum

@@ -786,6 +786,8 @@ github.com/mattn/go-runewidth v0.0.13/go.mod h1:Jdepj2loyihRzMpdS35Xk/zdY8IAYHsh
 github.com/mattn/go-runewidth v0.0.16 h1:E5ScNMtiwvlvB5paMFdw9p4kSQzbXFikJ5SQO6TULQc=
 github.com/mattn/go-runewidth v0.0.16/go.mod h1:Jdepj2loyihRzMpdS35Xk/zdY8IAYHsh153qUoGf23w=
 github.com/mattn/go-shellwords v1.0.4/go.mod h1:3xCvwCdWdlDJUrvuMn7Wuy9eWs4pE8vqg+NOMyg4B2o=
+github.com/mattn/go-shellwords v1.0.12 h1:M2zGm7EW6UQJvDeQxo4T51eKPurbeFbe8WtebGE2xrk=
+github.com/mattn/go-shellwords v1.0.12/go.mod h1:EZzvwXDESEeg03EKmM+RmDnNOPKG4lLtQsUlTZDWQ8Y=
 github.com/mattn/go-zglob v0.0.6 h1:mP8RnmCgho4oaUYDIDn6GNxYk+qJGUs8fJLn+twYj2A=
 github.com/mattn/go-zglob v0.0.6/go.mod h1:MxxjyoXXnMxfIpxTK2GAkw1w8glPsQILx3N5wrKakiY=
 github.com/matttproud/golang_protobuf_extensions v1.0.1/go.mod h1:D8He9yQNgCq6Z5Ld7szi9bcBfOoFv/3dc6xSMkL2PC0=