fix: Fixing visible flags (#4088)

* fix: Fixing visible subcommands and flags

* fix: Fixing implementation for subcommands, as that was fine

Author: yhakbar

internal/cli/command.go

@@ -105,7 +105,7 @@ func (cmd *Command) Subcommand(name string) *Command {
 
 // VisibleFlags returns a slice of the Flags, used by `urfave/cli` package to generate help.
 func (cmd *Command) VisibleFlags() Flags {
-	return cmd.Flags
+	return cmd.Flags.VisibleFlags()
 }
 
 // VisibleSubcommands returns a slice of the Commands with Hidden=false.

internal/cli/flags.go

@@ -44,7 +44,7 @@ func (flags Flags) Get(name string) Flag {
 
 // Filter returns a list of flags filtered by the given names.
 func (flags Flags) Filter(names ...string) Flags {
-	var filtered Flags
+	var filtered = make(Flags, 0, len(names))
 
 	for _, flag := range flags {
 		for _, name := range names {
@@ -65,7 +65,7 @@ func (flags Flags) Add(newFlags ...Flag) Flags {
 // VisibleFlags returns a slice of the Flags.
 // Used by `urfave/cli` package to generate help.
 func (flags Flags) VisibleFlags() Flags {
-	var visibleFlags Flags
+	var visibleFlags = make(Flags, 0, len(flags))
 
 	for _, flag := range flags {
 		if !flag.GetHidden() {