Skip to content

Commit 07ddb72

Browse files
committed
don't error if no source image id was not passed
1 parent eb9515f commit 07ddb72

1 file changed

Lines changed: 4 additions & 8 deletions

File tree

packer/registry/image/image.go

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,6 @@ func (i *Image) Validate() error {
5050
return errors.New("error registry image does not contain a valid ProviderName")
5151
}
5252

53-
if i.SourceImageID == "" {
54-
return errors.New("error registry image does not contain a valid SourceImageID")
55-
}
56-
5753
return nil
5854
}
5955

@@ -70,7 +66,6 @@ func (i *Image) String() string {
7066
// calling f(k,v). The func f is responsible for type asserting the expected type for the key and value before
7167
// trying to create an Image from it.
7268
func FromMappedData(mappedData interface{}, f func(key, value interface{}) (*Image, error)) ([]*Image, error) {
73-
7469
mapValue := reflect.ValueOf(mappedData)
7570
if mapValue.Kind() != reflect.Map {
7671
return nil, errors.New("error the incoming mappedData does not appear to be a map; found type to be" + mapValue.Kind().String())
@@ -99,9 +94,10 @@ func FromArtifact(a packer.Artifact, opts ...ArtifactOverrideFunc) (*Image, erro
9994
}
10095

10196
img := Image{
102-
ProviderName: a.BuilderId(),
103-
ImageID: a.Id(),
104-
Labels: make(map[string]string),
97+
ProviderName: a.BuilderId(),
98+
ImageID: a.Id(),
99+
Labels: make(map[string]string),
100+
SourceImageID: "",
105101
}
106102

107103
for _, opt := range opts {

0 commit comments

Comments
 (0)