Remove subcategory field from frontmatter in default provider template. (#446)

* Remove subcategory field from frontmatter in default provider template.

* Fix failing tests

* Add changelog entry

---------

Co-authored-by: Selena Goods <github@simplebox.anonaddy.com>

Author: jedesroches

.changes/unreleased/BUG FIXES-20250613-152846.yaml

@@ -0,0 +1,5 @@
+kind: BUG FIXES
+body: 'generate: Remove `subcategory` field from default provider templates'
+time: 2025-06-13T15:28:46.039473-04:00
+custom:
+    Issue: "446"

cmd/tfplugindocs/testdata/scripts/provider-build/generate/framework_provider_success_no_templates.txtar

@@ -68,7 +68,6 @@ data "scaffolding_example" "example" {
 ---
 # generated by https://github.com/hashicorp/terraform-plugin-docs
 page_title: "scaffolding Provider"
-subcategory: ""
 description: |-
   Example provider
 ---

cmd/tfplugindocs/testdata/scripts/schema-json/generate/framework_provider_success_all_framework_types.txtar

@@ -32,7 +32,6 @@ rendering "resources/example.md.tmpl"
 ---
 # generated by https://github.com/hashicorp/terraform-plugin-docs
 page_title: "scaffolding Provider"
-subcategory: ""
 description: |-
   Example provider
 ---

cmd/tfplugindocs/testdata/scripts/schema-json/generate/framework_provider_success_no_templates.txtar

@@ -103,7 +103,6 @@ example(input string, variadicInput string...) string
 ---
 # generated by https://github.com/hashicorp/terraform-plugin-docs
 page_title: "scaffolding Provider"
-subcategory: ""
 description: |-
   Example provider
 ---

cmd/tfplugindocs/testdata/scripts/schema-json/generate/nested_id_attribute.txtar

@@ -29,7 +29,6 @@ rendering "resources/example.md.tmpl"
 ---
 # generated by https://github.com/hashicorp/terraform-plugin-docs
 page_title: "scaffolding Provider"
-subcategory: ""
 description: |-
   Example provider
 ---

internal/provider/template.go

@@ -331,7 +331,6 @@ description: |-
 const defaultProviderTemplate providerTemplate = `---
 ` + frontmatterComment + `
 page_title: "{{.ProviderShortName}} Provider"
-subcategory: ""
 description: |-
 {{ .Description | plainmarkdown | trimspace | prefixlines "  " }}
 ---