Conversation
austinvalle
left a comment
There was a problem hiding this comment.
All the changes here look good! Two general comments to consider:
- We'll want to add a callout somewhere on the markdown page, like
-> Write-only attributes are supported in Terraform 1.11 and later.(we already started a thread offline about it) - We'll want a changelog for this new functionality!
Co-authored-by: Austin Valle <austinvalle@gmail.com>
Added the changelog but decided maybe we should just merge this PR and later add the link to write-only docs when it is available and the render logic for printing out that it is only supported in Terraform 1.11 in a different PR. |
austinvalle
left a comment
There was a problem hiding this comment.
... but decided maybe we should just merge this PR and later add the link to write-only docs when it is available and the render logic for printing out that it is only supported in Terraform 1.11 in a different PR.
Yeah if you want to open a separate PR for that before we release v0.21.0 of plugin-docs, sounds good to me! 🚀
For the
generatecommand, updated the render logic using terraform-json to addWriteOnly.For an example JSON Attribute:
We get the following md: