all: Add support for unknown value refinement data to all validators#250
Closed
austinvalle wants to merge 14 commits intomainfrom
Closed
all: Add support for unknown value refinement data to all validators#250austinvalle wants to merge 14 commits intomainfrom
austinvalle wants to merge 14 commits intomainfrom
Conversation
austinvalle
commented
Dec 4, 2024
Comment on lines
+9
to
+10
| github.com/hashicorp/terraform-plugin-framework v1.13.1-0.20241203155412-a2d406602012 | ||
| github.com/hashicorp/terraform-plugin-go v0.25.1-0.20241126200214-bd716fcfe407 |
Member
Author
There was a problem hiding this comment.
TODO: update with released versions
Member
Author
|
I'm going to close this PR as I'm no longer working on the team that owns this repo so it's unlikely this PR will get merged. Any future work from the maintainers around value refinements can use this PR as reference 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: hashicorp/terraform-plugin-go#448
Ref: hashicorp/terraform-plugin-framework#1062
Ref: hashicorp/terraform#30937
This PR introduces value refinement support for all relevant validators, based on upcoming changes to
terraform-plugin-frameworkto allow reading unknown value refinement data (first available in Terraform 1.6).Value refinements are additional constraints that can be applied to unknown values in Terraform that can be used to produce known results from unknown values. The data from these value refinements can be used to raise earlier diagnostics in validators, the available data being:
Existing behavior of validators when encountering fully unknown values remain unchanged (either because no refinement data exists, or an older version of Terraform is being used).
TODOs left on this PR
terraform-plugin-goandterraform-plugin-framework, once that's ready