Conversation
This is one step in removing a dependency on a no-longer-maintained Go module. Related: hashicorp/terraform-plugin-testing#254
austinvalle
reviewed
Oct 8, 2025
Member
austinvalle
left a comment
austinvalle
left a comment
There was a problem hiding this comment.
Changes look good, I did have a question since I'm not super familiar with this function's usage.
Can we add a changelog as well? Maybe even release the Go module since terraform-plugin-log hasn't been released in 2 years 😆
austinvalle
previously approved these changes
Oct 8, 2025
Member
austinvalle
left a comment
austinvalle
left a comment
There was a problem hiding this comment.
Code looks good to me, if you want to add a changelog here I can re-approve or a separate PR is also fine
Contributor
Author
Added 🏁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
hashicorp/terraform-plugin-testing#254
Description
This is one step in removing a dependency on a no-longer-maintained Go module.
As an estimate of impact:
gh search code RegisterTestSink language:goshows 29 results. 11 of those results are in thehashicorporg. This feels manageable.Rollback Plan
Changes to Security Controls
None.