resource/aws_ses_configuration_set: Add delivery options to allow a TlsPolicy of Require to be specified

[marcjay]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11197

Release note for CHANGELOG:

resource/aws_ses_configuration_set: Add `tls_policy` attribute to support requiring TLS as a `delivery_option`

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSESConfigurationSet'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSESConfigurationSet -timeout 120m
=== RUN   TestAccAWSSESConfigurationSet_basic
=== PAUSE TestAccAWSSESConfigurationSet_basic
=== RUN   TestAccAWSSESConfigurationSet_deliveryOptions
=== PAUSE TestAccAWSSESConfigurationSet_deliveryOptions
=== RUN   TestAccAWSSESConfigurationSet_deliveryOptionsUpdate
=== PAUSE TestAccAWSSESConfigurationSet_deliveryOptionsUpdate
=== CONT  TestAccAWSSESConfigurationSet_basic
=== CONT  TestAccAWSSESConfigurationSet_deliveryOptionsUpdate
=== CONT  TestAccAWSSESConfigurationSet_deliveryOptions
--- PASS: TestAccAWSSESConfigurationSet_deliveryOptions (19.28s)
--- PASS: TestAccAWSSESConfigurationSet_basic (19.53s)
--- PASS: TestAccAWSSESConfigurationSet_deliveryOptionsUpdate (32.71s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	32.772s

[marcjay]

This is based on the potential syntax on #11197 - if there is a preference for a different syntax, I'm happy to update this PR

[marcjay]

Many thanks @richmidwinter for the approval. What's the next step for getting this merged? Cheers

[marcjay]

Any chance of an update on this please? Appreciate that some PRs are more important than others but this is fairly small all things considered. Would really appreciate this being merged. Many thanks

[bmoylan]

We would love to see this get in as well. @bflad are you the right reviewer here? Thanks in advance!

[marcjay]

Re-ran the acceptance tests after resolving the merge conflicts:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSESConfigurationSet'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSESConfigurationSet -timeout 120m
=== RUN   TestAccAWSSESConfigurationSet_basic
=== PAUSE TestAccAWSSESConfigurationSet_basic
=== RUN   TestAccAWSSESConfigurationSet_deliveryOptions
=== PAUSE TestAccAWSSESConfigurationSet_deliveryOptions
=== RUN   TestAccAWSSESConfigurationSet_deliveryOptionsUpdate
=== PAUSE TestAccAWSSESConfigurationSet_deliveryOptionsUpdate
=== CONT  TestAccAWSSESConfigurationSet_basic
=== CONT  TestAccAWSSESConfigurationSet_deliveryOptionsUpdate
=== CONT  TestAccAWSSESConfigurationSet_deliveryOptions
--- PASS: TestAccAWSSESConfigurationSet_deliveryOptions (16.81s)
--- PASS: TestAccAWSSESConfigurationSet_basic (16.92s)
--- PASS: TestAccAWSSESConfigurationSet_deliveryOptionsUpdate (27.18s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	28.632s

[nyetsche]

@richmidwinter are you able to review and merge? We're very interested in seeing this reach mainline. Thanks.

[marcjay]

Re-ran the acceptance tests after merging master and adopting TestCheckTypeSetElemNestedAttrs:

$ make testacc TESTARGS='-run=TestAccAWSSESConfigurationSet'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSESConfigurationSet -timeout 120m
=== RUN   TestAccAWSSESConfigurationSet_basic
=== PAUSE TestAccAWSSESConfigurationSet_basic
=== RUN   TestAccAWSSESConfigurationSet_deliveryOptions
=== PAUSE TestAccAWSSESConfigurationSet_deliveryOptions
=== RUN   TestAccAWSSESConfigurationSet_deliveryOptionsUpdate
=== PAUSE TestAccAWSSESConfigurationSet_deliveryOptionsUpdate
=== CONT  TestAccAWSSESConfigurationSet_basic
=== CONT  TestAccAWSSESConfigurationSet_deliveryOptionsUpdate
=== CONT  TestAccAWSSESConfigurationSet_deliveryOptions
--- PASS: TestAccAWSSESConfigurationSet_basic (9.93s)
--- PASS: TestAccAWSSESConfigurationSet_deliveryOptions (9.98s)
--- PASS: TestAccAWSSESConfigurationSet_deliveryOptionsUpdate (15.92s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	17.482s

[marcjay]

Hi @richmidwinter / @bflad - is there any chance this could be looked at/merged? It's not much fun dealing with merge conflicts when they pop up and it's been open for 9 months now. Many thanks

[voycey]

Any update on this? We have a pretty heavy requirement for this configuration set to be enabled

[anGie44]

Hi @marcjay 👋 Thank you for your work on this PR! In order to expedite the process and get this into our upcoming release, I'm going to rebase and likely make some minor adjustments. Make sure that you have checked the box "Allow edits from maintainers." Also, please coordinate with us before making any commits to this branch. Again, thank you for your help and we look forward to this popular addition to the AWS provider!

[anGie44]

Output of acceptance tests (commercial):

--- PASS: TestAccAWSSESConfigurationSet_basic (14.28s)
--- PASS: TestAccAWSSESConfigurationSet_emptyDeliveryOptions (14.66s)
--- PASS: TestAccAWSSESConfigurationSet_deliveryOptions (15.44s)
--- PASS: TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions (31.54s)
--- PASS: TestAccAWSSESConfigurationSet_update_deliveryOptions (39.64s)

[anGie44]

Thanks again @marcjay! 🚀

[marcjay]

Thanks again @marcjay! 🚀

@anGie44 thanks for getting it merged! Great to have it in at last

[ghost]

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!